This change improves clarity of code:
- An unit was expressed in bytes, requiring to know 1024 multiples to figure it.
- Explain the sv restart phd line at the end.
Details
Details
$ sh $ echo $((8*1024*1024)) 8388608
Diff Detail
Diff Detail
- Repository
- rDPHAB Docker image for Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Test plan is what has been used to check.
Personally, I did that:
ysul
$ sh $ echo $((8*1024*1024)) 8388608
| files/usr/local/bin/setup-phabricator | ||
|---|---|---|
| 50 | If we want to explain final steps what about somehing like this? # We're done with configuration. # Final step is to restart the Phabricator daemons to refresh configuration. # The .initialized file means "this script has been launched and succeeded". | |
Comment Actions
I wonder if the shell variables should not be quoted for example
"$MYSQL_ENV_MYSQL_ROOT_PASSWORD" instead of $MYSQL_ENV_MYSQL_ROOT_PASSWORD
to take account that they could contain shell separator such as space
| files/usr/local/bin/setup-phabricator | ||
|---|---|---|
| 50 | looks good. # Final step is to restart the Phabricator daemons to reload configuration. (reload instead of refresh) | |
Comment Actions
- adding quote to command arguments
The purpose of this commit is to avoid interpretation of special
character by shell