Page MenuHomeDevCentral

only touch .initialized on success of service restart
Needs RevisionPublic

Authored by xcombelle on Aug 8 2016, 23:32.

Details

Reviewers
dereckson
Test Plan

make the service fail somehow.
On original the .initialized file should be created anyway
On new version there is no .initialized file created

Diff Detail

Repository
rDPHAB Docker image for Phabricator
Lint
No Linters Available
Unit
No Unit Test Coverage
Branch
good-restart
Build Status
Buildable 892
Build 1033: arc lint + arc unit

Event Timeline

xcombelle updated this revision to Diff 1471.Aug 8 2016, 23:32
xcombelle retitled this revision from to only touch .initialized on succes of service restart.
xcombelle updated this object.
xcombelle edited the test plan for this revision. (Show Details)
xcombelle added a reviewer: dereckson.
dereckson edited edge metadata.Aug 16 2016, 19:18

To fail on error is probably a good idea to avoid to say .initialized when an error occurs

So a good approach could be http://www.gnu.org/software/bash/manual/bashref.html#The-Set-Builtin

dereckson retitled this revision from only touch .initialized on succes of service restart to only touch .initialized on success of service restart.Aug 16 2016, 19:20
dereckson edited edge metadata.
dereckson added a comment.EditedAug 18 2016, 22:56

That would be set -e

dereckson requested changes to this revision.Aug 18 2016, 22:56
dereckson edited edge metadata.
This revision now requires changes to proceed.Aug 18 2016, 22:56