Page MenuHomeDevCentral
Differential D626

Analyze Jenkins payloads
ClosedPublic
Actions

Authored by dereckson on Aug 21 2016, 01:39.
Tags
None
Referenced Files
F2829005: D626.id1552.diff
Fri, Apr 19, 06:39
F2826839: D626.id1550.diff
Thu, Apr 18, 21:43
F2826040: D626.id1554.diff
Thu, Apr 18, 18:36
Unknown Object (File)
Thu, Apr 18, 01:37
Unknown Object (File)
Sun, Apr 14, 10:29
Unknown Object (File)
Sat, Apr 13, 00:05
Unknown Object (File)
Thu, Apr 11, 02:02
Unknown Object (File)
Tue, Apr 9, 13:57
View All Files
Subscribers
alken-orin
dereckson

Details

Reviewers
dereckson
Maniphest Tasks
T953: Handle Jenkins notification plugin payloads
Commits
rNOTIFf8a79171e10d: Analyze Jenkins payloads
Summary

Commit 827b3ab83659 introduced a schema for Jenkins configuration.

This change implements the analyzer code for this configuration.

Ref T953.

Test Plan

Unit tests based on GitHub webhooks analyser code.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1550.Aug 21 2016, 01:39
dereckson retitled this revision from to Analyze Jenkins payload.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a subscriber: dereckson.
dereckson retitled this revision from Analyze Jenkins payload to Analyze Jenkins payloads.Aug 21 2016, 01:41
dereckson updated this object.
dereckson added a reviewer: dereckson.
dereckson added a task: T953: Handle Jenkins notification plugin payloads.
alken-orin added a subscriber: alken-orin.Aug 21 2016, 01:54

Build is green https://ci.nasqueron.org/job/test-notifications-phab/163/ for more details.

dereckson mentioned this in D627: ItemGroupMapping generic class.Aug 22 2016, 20:28
dereckson updated this revision to Diff 1552.Aug 22 2016, 20:33
dereckson edited edge metadata.

Rebased against D627.

alken-orin added a comment.Aug 22 2016, 20:49

Build is green https://ci.nasqueron.org/job/test-notifications-phab/165/ for more details.

dereckson updated this revision to Diff 1553.Aug 22 2016, 20:54
dereckson edited edge metadata.

Analyze group.

dereckson updated this revision to Diff 1554.Aug 22 2016, 20:55

Don't take D627 with us.

alken-orin added a comment.Aug 22 2016, 21:08

Build is green https://ci.nasqueron.org/job/test-notifications-phab/166/ for more details.

alken-orin added a comment.Aug 22 2016, 21:08

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/167/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/167/console

dereckson mentioned this in rNOTIF6d1f7edde154: ItemGroupMapping generic class.Aug 22 2016, 21:12
dereckson updated this revision to Diff 1556.Aug 22 2016, 21:13

Rebased against merged D627.

alken-orin added a comment.Aug 22 2016, 21:27

Build is green https://ci.nasqueron.org/job/test-notifications-phab/168/ for more details.

dereckson updated this revision to Diff 1557.Aug 22 2016, 21:37

Moved notify only on failure methods from configuration (in this diff) to analyzer (in another diff)

alken-orin added a comment.Aug 22 2016, 21:52

Build is green https://ci.nasqueron.org/job/test-notifications-phab/169/ for more details.

dereckson accepted this revision.Aug 23 2016, 01:13
dereckson edited edge metadata.
This revision is now accepted and ready to land.Aug 23 2016, 01:13
Closed by commit rNOTIFf8a79171e10d: Analyze Jenkins payloads (authored by dereckson, committed by dereckson). · Explain WhyAug 23 2016, 01:14
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Analyzers/
Jenkins/
120 lines
72 lines
Notifications/
23 lines
config/
6 lines
tests/
Analyzers/
Jenkins/
62 lines
data/
JenkinsPayloadAnalyzer/
27 lines
5 lines

Diff 1559

View Options

app/Analyzers/Jenkins/JenkinsPayloadAnalyzer.php

Loading...
View Options

app/Analyzers/Jenkins/JenkinsPayloadAnalyzerConfiguration.php

Loading...
View Options

app/Notifications/JenkinsNotification.php

Loading...
View Options

config/services.php

Loading...
View Options

tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerConfigurationTest.php

Loading...
View Options

tests/data/JenkinsPayloadAnalyzer/Nasqueron.json

Loading...
View Options

tests/data/JenkinsPayloadAnalyzer/default.json

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator