Differential D634

Fix PhabricatorStory::attachProjects undefined property issue
ClosedPublic
Actions

Authored by dereckson on Aug 24 2016, 01:50.

Details

Reviewers

dereckson

Commits

rNOTIF6008238689ff: Fix PhabricatorStory::attachProjects undefined property issue

Summary

This fixes the following issue:
Undefined property: Nasqueron\Notifications\Phabricator\PhabricatorStory::$instance

A code comment update was also needed for loadFromArray.

This is a follow-up for 67730e913d04.

Test Plan

Tested when fixing the notifications:payloads command for Phabricator

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1581.Aug 24 2016, 01:50

dereckson retitled this revision from to Fix PhabricatorStory::attachProjects undefined property issue.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Aug 24 2016, 01:51

dereckson updated this object.

dereckson edited edge metadata.

This revision is now accepted and ready to land.Aug 24 2016, 01:51

Closed by commit rNOTIF6008238689ff: Fix PhabricatorStory::attachProjects undefined property issue (authored by dereckson, committed by dereckson). · Explain WhyAug 24 2016, 01:52

This revision was automatically updated to reflect the committed changes.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/182/ for more details.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

PhabricatorStory.php

4 lines

Diff 1582

View Options

app/Phabricator/PhabricatorStory.php

Fix PhabricatorStory::attachProjects undefined property issueClosedPublicActions