Page MenuHomeDevCentral

Require Laravel 5.2, but not Laravel 5.3
ClosedPublic

Authored by dereckson on Aug 31 2016, 15:35.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 16, 17:54
Unknown Object (File)
Mon, May 13, 07:57
Unknown Object (File)
Mon, May 13, 00:27
Unknown Object (File)
Fri, May 10, 14:08
Unknown Object (File)
Wed, May 8, 18:36
Unknown Object (File)
Mon, May 6, 12:51
Unknown Object (File)
Sun, May 5, 00:32
Unknown Object (File)
Fri, May 3, 21:12
Subscribers

Details

Summary

The Docker Image doesn't build, as at artisan optimize step,
a fatal error occurs, as our EventServiceProvider::boot() isn't
compatible anymore with parent class signature.

This is caused by two factors:

  • upstream: commit fa9f3220 made the class boot method now use facades instead of dependency injection to the method
  • locally: commit d69820ed127c required Laravel 5.2.41+ to get session code update, but didn't guard agaisnt 5.3.*

We require 5.2.*, using ~ and not ^ in Composer version syntax.
The caret operator is more appropraited when semver is better followed.

References:

This is a follow-up for d69820ed127c.
Fixes T997.

Test Plan

Ensure composer install latest 5.2:

$ rm -rf vendor/
$ composer install

  - Installing laravel/framework (v5.2.39)
    Loading from cache

Diff Detail

Repository
rGROVE Auth Grove
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson retitled this revision from to Require Laravel 5.2, but not Laravel 5.3.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: Sandlayth.
Sandlayth edited edge metadata.
This revision is now accepted and ready to land.Aug 31 2016, 16:27
This revision was automatically updated to reflect the committed changes.