D1542.id3938.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D1542.id3938.diff
View Options

	diff --git a/app/Phabricator/PhabricatorStory.php b/app/Phabricator/PhabricatorStory.php
	--- a/app/Phabricator/PhabricatorStory.php
	+++ b/app/Phabricator/PhabricatorStory.php
	@@ -315,9 +315,8 @@
	return "id";
	}

	- if (starts_with($key, "story")) {
	- $key = substr($key, 5);
	- $key[0] = strtolower($key[0]); // lowercase
	+ if (starts_with($key, "story") && strlen($key) > 5) {
	+ return lcfirst(substr($key, 5));
	}

	return $key;
	diff --git a/tests/Phabricator/PhabricatorStoryTest.php b/tests/Phabricator/PhabricatorStoryTest.php
	--- a/tests/Phabricator/PhabricatorStoryTest.php
	+++ b/tests/Phabricator/PhabricatorStoryTest.php
	@@ -22,4 +22,22 @@
	yield ["VOID", ['foo' => 'bar']];
	yield ["TASK", ['objectPHID' => 'PHID-TASK-l34fw5wievp6n6rnvpuk']];
	}
	+
	+ /**
	+ * @dataProvider provideKeys
	+ */
	+ public function testMapPhabricatorFeedKey ($expected, $key) {
	+ $this->assertEquals(
	+ $expected,
	+ PhabricatorStory::mapPhabricatorFeedKey($key)
	+ );
	+ }
	+
	+ public function provideKeys () : iterable {
	+ yield ['id', 'storyID'];
	+ yield ['id', 'storyId'];
	+ yield ['task', 'storyTask'];
	+ yield ['story', 'story'];
	+ yield ['', ''];
	+ }
	}