Page MenuHomeDevCentral

D1544.diff
No OneTemporary

D1544.diff

diff --git a/app/Phabricator/PhabricatorStory.php b/app/Phabricator/PhabricatorStory.php
--- a/app/Phabricator/PhabricatorStory.php
+++ b/app/Phabricator/PhabricatorStory.php
@@ -123,13 +123,17 @@
/// Helper methods
///
+ private function hasVoidObjectType () : bool {
+ return $this->data === null || !isset($this->data['objectPHID']);
+ }
+
/**
* Gets object type (e.g. TASK for PHID-TASK-l34fw5wievp6n6rnvpuk)
*
* @return string The object type, as a 4 letters string (e.g. 'TASK')
*/
public function getObjectType () {
- if ($this->data === null || !array_key_exists('objectPHID', $this->data)) {
+ if ($this->hasVoidObjectType()) {
return 'VOID';
}

File Metadata

Mime Type
text/plain
Expires
Sun, Nov 17, 11:24 (21 h, 28 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2249284
Default Alt Text
D1544.diff (752 B)

Event Timeline