Page MenuHomeDevCentral
Files F3750178

D218.diff
No OneTemporary
Actions

D218.diff
View Options

diff --git a/tests/Http/PayloadFullTest.php b/tests/Http/PayloadFullTest.php
--- a/tests/Http/PayloadFullTest.php
+++ b/tests/Http/PayloadFullTest.php
@@ -2,6 +2,9 @@
namespace Nasqueron\Notifications\Tests;
+use Keruald\Broker\BlackholeBroker;
+use Nasqueron\Notifications\Features;
+
class PayloadFullTest extends TestCase {
public function setUp () {
@@ -11,9 +14,20 @@
}
/**
- * Tests a GitHub gate payload.
+ * Sends a GitHub ping payload to the application, with a valid signature
*/
- public function testPost () {
+ protected function sendValidTestPayload () {
+ return $this->sendTestPayload('sha1=25f6cbd17ea4c6c69958b95fb88c879de4b66dcc');
+ }
+
+ /**
+ * Sends a GitHub ping payload to the application, with a valid signature
+ */
+ protected function sendInvalidTestPayload () {
+ return $this->sendTestPayload('sha1=somethingwrong');
+ }
+
+ protected function sendTestPayload ($signature) {
$payload = file_get_contents(__DIR__ . '/../data/GitHubPingPayload.json');
$this->sendPayload(
'/gate/GitHub/Acme', // A gate existing in data/credentials.json
@@ -22,9 +36,17 @@
[
'X-Github-Event' => 'ping',
'X-Github-Delivery' => 'e5dd9fc7-17ac-11e5-9427-73dad6b9b17c',
- 'X-Hub-Signature' => 'sha1=25f6cbd17ea4c6c69958b95fb88c879de4b66dcc',
+ 'X-Hub-Signature' => $signature,
]
- )->seeJson([
+ );
+ return $this;
+ }
+
+ /**
+ * Tests a GitHub gate payload.
+ */
+ public function testPost () {
+ $this->sendValidTestPayload()->seeJson([
'gate' => 'GitHub',
'door' => 'Acme',
'action' => 'AMQPAction'
@@ -34,21 +56,33 @@
}
/**
+ * Same than testPost, but without actions report.
+ */
+ public function testPostWithoutActionsReport () {
+ Features::disable("ActionsReport");
+
+ $this->sendValidTestPayload();
+ $this->assertEmpty($this->response->getContent());
+ $this->assertResponseOk();
+
+ // Let's throw an Exception at broker level.
+ // Without ActionsReport, the client must always receive a 200 OK.
+
+ $this->app->instance('broker', function ($app) {
+ // A non omnipotent instance, so it doesn't mock connect().
+ return new BlackholeBroker;
+ });
+ $this->sendValidTestPayload();
+ $this->assertEmpty($this->response->getContent());
+ $this->assertResponseOk();
+ }
+
+ /**
* Tests a GitHub gate payload.
*/
public function testInvalidSignature () {
- $payload = file_get_contents(__DIR__ . '/../data/GitHubPingPayload.json');
- $this->sendPayload(
- '/gate/GitHub/Acme', // A gate existing in data/credentials.json
- $payload,
- 'POST',
- [
- 'X-Github-Event' => 'ping',
- 'X-Github-Delivery' => 'e5dd9fc7-17ac-11e5-9427-73dad6b9b17c',
- 'X-Hub-Signature' => 'sha1=somethingwrong',
- ]
- );
- $this->assertResponseStatus(403);
+ $this->sendInvalidTestPayload()
+ ->assertResponseStatus(403);
}
public function testBrokerIssue () {

File Metadata

Mime Type
text/plain
Expires
Sun, Nov 17, 21:58 (20 h, 20 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2249868
Default Alt Text
D218.diff (3 KB)

Event Timeline

Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator