Page MenuHomeDevCentral
Files F3751024

D1066.id2729.diff
No OneTemporary
Actions

D1066.id2729.diff
View Options

diff --git a/app/Actions/ActionError.php b/app/Actions/ActionError.php
--- a/app/Actions/ActionError.php
+++ b/app/Actions/ActionError.php
@@ -21,7 +21,7 @@
/**
* Initializes a new action error report instance from the specified Exception
*
- * @param Exception $ex The exception to build an ActionError instance from
+ * @param \Exception $ex The exception to build an ActionError instance from
*/
public function __construct (\Exception $ex) {
$this->type = class_basename(get_class($ex));
diff --git a/app/Analyzers/GitHub/Events/IssueCommentEvent.php b/app/Analyzers/GitHub/Events/IssueCommentEvent.php
--- a/app/Analyzers/GitHub/Events/IssueCommentEvent.php
+++ b/app/Analyzers/GitHub/Events/IssueCommentEvent.php
@@ -12,7 +12,7 @@
/**
* Determines if the action is valid.
*
- * @param string $type The action to check
+ * @param string $action The action to check
* @return bool true if the action is valid; otherwise, false
*/
protected static function isValidAction ($action) {
diff --git a/app/Analyzers/GitHub/Events/PullRequestEvent.php b/app/Analyzers/GitHub/Events/PullRequestEvent.php
--- a/app/Analyzers/GitHub/Events/PullRequestEvent.php
+++ b/app/Analyzers/GitHub/Events/PullRequestEvent.php
@@ -12,7 +12,7 @@
/**
* Determines if the action is valid.
*
- * @param string $type The action to check
+ * @param string $action The action to check
* @return bool true if the action is valid; otherwise, false
*/
protected static function isValidAction ($action) {
diff --git a/app/Analyzers/GitHub/Events/RepositoryEvent.php b/app/Analyzers/GitHub/Events/RepositoryEvent.php
--- a/app/Analyzers/GitHub/Events/RepositoryEvent.php
+++ b/app/Analyzers/GitHub/Events/RepositoryEvent.php
@@ -12,7 +12,7 @@
/**
* Determines if the action is valid.
*
- * @param string $type The action to check
+ * @param string $action The action to check
* @return bool true if the action is valid; otherwise, false
*/
protected static function isValidAction ($action) {
diff --git a/app/Console/Kernel.php b/app/Console/Kernel.php
--- a/app/Console/Kernel.php
+++ b/app/Console/Kernel.php
@@ -52,7 +52,7 @@
/**
* Gets a command by class
*
- * @param string $name The command class
+ * @param string $class The command class
* @return \Illuminate\Console\Command
* @throws \RuntimeException when command doesn't exit
*/
diff --git a/app/Events/ReportEvent.php b/app/Events/ReportEvent.php
--- a/app/Events/ReportEvent.php
+++ b/app/Events/ReportEvent.php
@@ -17,7 +17,7 @@
/**
* Creates a new event instance.
*
- * @param ActionReport $action the action to report
+ * @param Action $action the action to report
*/
public function __construct(Action $action) {
$this->action = $action;
diff --git a/app/Http/Controllers/Gate/NotificationGateController.php b/app/Http/Controllers/Gate/NotificationGateController.php
--- a/app/Http/Controllers/Gate/NotificationGateController.php
+++ b/app/Http/Controllers/Gate/NotificationGateController.php
@@ -21,7 +21,7 @@
/**
* The request content, as a structured data
*
- * @var \stdClass
+ * @var \Nasqueron\Notifications\Notifications\Notification
*/
private $payload;
@@ -88,10 +88,10 @@
}
$mapper = new \JsonMapper();
- return $mapper->map(
+ return (Notification)($mapper->map(
$payload,
new Notification
- );
+ ));
}
private function normalizePayload () : void {
diff --git a/app/Jobs/FireDockerHubNotification.php b/app/Jobs/FireDockerHubNotification.php
--- a/app/Jobs/FireDockerHubNotification.php
+++ b/app/Jobs/FireDockerHubNotification.php
@@ -40,8 +40,7 @@
/**
* Creates a DockerHub notification
*
- * @param DockerHubPayloadEvent $event
- * @return \Nasqueron\Notifications\Notifications\Notification The notification
+ * @return \Nasqueron\Notifications\Notifications\DockerHubNotification The notification
*/
protected function createNotification() : DockerHubNotification {
return new DockerHubNotification(
diff --git a/app/Jobs/FireGitHubNotification.php b/app/Jobs/FireGitHubNotification.php
--- a/app/Jobs/FireGitHubNotification.php
+++ b/app/Jobs/FireGitHubNotification.php
@@ -40,8 +40,7 @@
/**
* Creates a GitHub notification
*
- * @param GitHubPayloadEvent $event
- * @return \Nasqueron\Notifications\Notifications\Notification The notification
+ * @return \Nasqueron\Notifications\Notifications\GitHubNotification The notification
*/
protected function createNotification() : GitHubNotification {
return new GitHubNotification(
diff --git a/app/Jobs/FireJenkinsNotification.php b/app/Jobs/FireJenkinsNotification.php
--- a/app/Jobs/FireJenkinsNotification.php
+++ b/app/Jobs/FireJenkinsNotification.php
@@ -44,8 +44,7 @@
/**
* Creates a Jenkins notification
*
- * @param JenkinsPayloadEvent $event
- * @return \Nasqueron\Notifications\Notifications\Notification The notification
+ * @return \Nasqueron\Notifications\Notifications\JenkinsNotification The notification
*/
protected function createNotification() : JenkinsNotification {
return new JenkinsNotification(
diff --git a/app/Jobs/FirePhabricatorNotification.php b/app/Jobs/FirePhabricatorNotification.php
--- a/app/Jobs/FirePhabricatorNotification.php
+++ b/app/Jobs/FirePhabricatorNotification.php
@@ -40,8 +40,7 @@
/**
* Creates a Phabricator notification
*
- * @param PhabricatorPayloadEvent $event
- * @return \Nasqueron\Notifications\Notifications\Notification The notification
+ * @return \Nasqueron\Notifications\Notifications\PhabricatorNotification The notification
*/
protected function createNotification() : PhabricatorNotification {
return new PhabricatorNotification(
diff --git a/app/Listeners/AMQPEventListener.php b/app/Listeners/AMQPEventListener.php
--- a/app/Listeners/AMQPEventListener.php
+++ b/app/Listeners/AMQPEventListener.php
@@ -28,7 +28,7 @@
/**
* Gets routing key, to allow consumers to select the topic they subscribe to.
*
- * @param NotificationEvent $event
+ * @param Notification The $notification from where the keys must be extracted
*/
protected static function getNotificationRoutingKey (Notification $notification) : string {
$keyParts = [
diff --git a/app/Phabricator/ProjectsMap.php b/app/Phabricator/ProjectsMap.php
--- a/app/Phabricator/ProjectsMap.php
+++ b/app/Phabricator/ProjectsMap.php
@@ -65,7 +65,7 @@
/**
* Gets iterator.
*
- * @return Traversable
+ * @return \Traversable
*/
public function getIterator () {
return new \ArrayIterator($this->map);
@@ -140,7 +140,7 @@
* Gets a new ProjectsMap instance and queries Phabricator API to fill it.
*
* @param string $phabricatorInstanceName The Phabricator instance name
- * @param \Nasqueron\Notifications\Contracts\APIClient $apiClient The Phabricator API client
+ * @param \Nasqueron\Notifications\Contracts\APIClient|null $apiClient The Phabricator API client
* @return ProjectsMap
*/
public static function fetch ($phabricatorInstanceName, ?APIClient $apiClient = null) {

File Metadata

Mime Type
text/plain
Expires
Mon, Nov 18, 05:29 (21 h, 48 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2250196
Default Alt Text
D1066.id2729.diff (7 KB)

Event Timeline

Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator