D313.diff
View Options

	diff --git a/app/Exceptions/Handler.php b/app/Exceptions/Handler.php
	--- a/app/Exceptions/Handler.php
	+++ b/app/Exceptions/Handler.php
	@@ -36,11 +36,15 @@
	*/
	public function report(Exception $e)
	{
	+ if (!$this->shouldReport($e)) {
	+ return;
	+ }
	+
	if ($this->shouldReportToSentry()) {
	$this->reportToSentry($e);
	}

	- parent::report($e);
	+ $this->log->error($e);
	}

	/**
	diff --git a/tests/Exceptions/HandlerTest.php b/tests/Exceptions/HandlerTest.php
	--- a/tests/Exceptions/HandlerTest.php
	+++ b/tests/Exceptions/HandlerTest.php
	@@ -2,6 +2,7 @@

	namespace Nasqueron\Notifications\Tests\Exceptions;

	+use Illuminate\Auth\Access\AuthorizationException;
	use Nasqueron\Notifications\Exceptions\Handler;
	use Nasqueron\Notifications\Tests\TestCase;

	@@ -16,24 +17,38 @@
	*/
	private $handler;

	+ /**
	+ * Raven_Client
	+ */
	+ private $ravenClientMock;
	+
	public function setUp () {
	parent::setUp();

	$logger = App::make('log');
	$this->handler = new Handler($logger);
	+
	+ $this->mockRavenClient();
	}

	protected function mockRavenClient () {
	- $mock = Mockery::mock('Raven_Client');
	- $mock->shouldReceive('captureException')->once();
	+ // Inject into our container a mock of Raven_Client
	+ $this->ravenClientMock = Mockery::mock('Raven_Client');
	+ $this->app->instance('raven', $this->ravenClientMock);

	+ // Environment shouldn't be 'testing' and DSN should be defined,
	+ // so Handler::report will call Raven to report to Sentry
	Config::set('app.env', 'testing-raven');
	Config::set('services.sentry.dsn', 'mock');
	- $this->app->instance('raven', $mock);
	}

	public function testRavenReport () {
	- $this->mockRavenClient();
	+ $this->ravenClientMock->shouldReceive('captureException')->once();
	$this->handler->report(new \Exception);
	}
	+
	+ public function testExceptionInDontReportArray () {
	+ $this->ravenClientMock->shouldReceive('captureException')->never();
	+ $this->handler->report(new AuthorizationException);
	+ }
	}

File Metadata

Mime Type: text/plain
Expires: Mon, Nov 18, 08:38 (22 h, 12 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 2250474
Default Alt Text: D313.diff (2 KB)

D313.diff
No OneTemporary
Actions

D313.diff
View Options

File Metadata

Event Timeline

D313.diffNo OneTemporaryActions

D313.diffView Options

File Metadata

Event Timeline

D313.diff
No OneTemporary
Actions

D313.diff
View Options