Page MenuHomeDevCentral

D326.diff
No OneTemporary

D326.diff

diff --git a/app/Analyzers/Phabricator/PhabricatorGroupMapping.php b/app/Analyzers/Phabricator/PhabricatorGroupMapping.php
--- a/app/Analyzers/Phabricator/PhabricatorGroupMapping.php
+++ b/app/Analyzers/Phabricator/PhabricatorGroupMapping.php
@@ -67,7 +67,7 @@
*/
public function doesStoryBelong (PhabricatorStory $story) {
foreach ($this->words as $word) {
- if (strpos($story->text, $word) !== false) {
+ if (stripos($story->text, $word) !== false) {
return true;
}
}
diff --git a/tests/Analyzers/Phabricator/PhabricatorGroupMappingTest.php b/tests/Analyzers/Phabricator/PhabricatorGroupMappingTest.php
--- a/tests/Analyzers/Phabricator/PhabricatorGroupMappingTest.php
+++ b/tests/Analyzers/Phabricator/PhabricatorGroupMappingTest.php
@@ -112,4 +112,16 @@
);
}
+ /**
+ * Test to fix T773
+ */
+ public function testDoesStoryBelongWhenWordIsInAnotherCase () {
+ $mapping = $this->mappings['words'];
+
+ $this->story->text = "Review the Cartography elements.";
+ $this->assertTrue(
+ $mapping->doesStoryBelong($this->story)
+ );
+ }
+
}

File Metadata

Mime Type
text/plain
Expires
Fri, Dec 20, 03:47 (20 h, 49 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2307351
Default Alt Text
D326.diff (1 KB)

Event Timeline