Page MenuHomeDevCentral
Create Task
Maniphest T1179

If an array parameter is missing in ItemGroupMapping, populate [] or throw a clear exception
Closed, ResolvedPublic
Actions

Description

[2017-04-09 01:51:32] production.ERROR: ErrorException: Invalid argument supplied for foreach() in /var/wwwroot/default/app/Analyzers/ItemGroupMapping.php:51
Stack trace:
#1 /var/wwwroot/default/app/Analyzers/Phabricator/PhabricatorPayloadAnalyzer.php(57): Nasqueron\Notifications\Analyzers\ItemGroupMapping->doesItemBelong('easy'
)
#2 /var/wwwroot/default/app/Notifications/PhabricatorNotification.php(55): Nasqueron\Notifications\Analyzers\Phabricator\PhabricatorPayloadAnalyzer->getGroup()
#3 /var/wwwroot/default/app/Notifications/PhabricatorNotification.php(30): Nasqueron\Notifications\Notifications\PhabricatorNotification->getGroup()
#4 /var/wwwroot/default/app/Jobs/FirePhabricatorNotification.php(49): Nasqueron\Notifications\Notifications\PhabricatorNotification->__construct('Nasqueron', O
bject(Nasqueron\Notifications\Phabricator\PhabricatorStory))
#5 /var/wwwroot/default/app/Jobs/FirePhabricatorNotification.php(36): Nasqueron\Notifications\Jobs\FirePhabricatorNotification->createNotification()

Revisions and Commits

rNOTIF Notifications center
D947rNOTIF270f799958b8 Ensure ItemGroupMapping::$items is always an array

Related Objects

Event Timeline

dereckson created this task.Apr 9 2017, 01:52
dereckson added a comment.Apr 9 2017, 02:14

T1177 offers some validation, this exception is present when the items keyt isn't defined. to add items: [], solves the issue.

We should raise a custom exception in such situation.

dereckson renamed this task from Invalid argument supplied for foreach() in ItemGroupMapping to If an array parameter is missing in ItemGroupMapping, populate [] or throw a clear exception.Apr 9 2017, 10:25
dereckson removed dereckson as the assignee of this task.
dereckson lowered the priority of this task from High to Low.
dereckson raised the priority of this task from Low to Normal.
dereckson claimed this task.Apr 9 2017, 11:17

This is a case we can [] by default, okay taking this bug.

dereckson added a revision: D947: Ensure ItemGroupMapping::$items is always an array.Apr 9 2017, 12:16
dereckson closed this task as Resolved by committing rNOTIF270f799958b8: Ensure ItemGroupMapping::$items is always an array.Apr 9 2017, 12:20
dereckson added a commit: rNOTIF270f799958b8: Ensure ItemGroupMapping::$items is always an array.
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator