Page MenuHomeDevCentral
Create Task
Maniphest T1577

Arcanist ignores phpunit.xml to run unit tests in OmniTools
Closed, ResolvedPublic
Actions

Description

When arc unit runs after a change to src/Reflection/CodeFile.php, the tests are marked as broken.

If the tests are run without using phpunit.xml, the following error indeed occurs:

Fatal error: Trait 'Keruald\OmniTools\Tests\WithData' not found in /usr/home/dereckson/dev/keruald/omnitools/tests/Reflection/CodeFileTest.php on line 14

Event Timeline

dereckson triaged this task as High priority.Jan 28 2020, 07:17
dereckson created this task.
dereckson closed this task as Wontfix.Jan 28 2020, 07:25

This error occurs when tests are run from the tests/ folder:

$ cd tests
$ phpunit .

Fatal error: Trait 'Keruald\OmniTools\Tests\WithData' not found in /usr/home/dereckson/dev/keruald/omnitools/tests/Reflection/CodeFileTest.php on line 14

In root folder, phpunit.xml includes bootstrap="vendor/autoload.php" attribute to the phpunit tag. This allows to load following PSR-4 the objects in the Keruald\OmniTools\Tests namespace.

dereckson reopened this task as Open.Jan 28 2020, 07:28

arc unit doesn't take in consideration phpunit.xml

dereckson updated the task description. (Show Details)Jan 28 2020, 07:28
dereckson renamed this task from WithData trait missing in CodeFileTest class to Arcanist ignores phpunit.xml to run unit tests.Jan 28 2020, 10:22
dereckson renamed this task from Arcanist ignores phpunit.xml to run unit tests to Arcanist ignores phpunit.xml to run unit tests in OmniTools.
dereckson moved this task from Backlog to Bugs on the Keruald board.Feb 16 2020, 04:21
dereckson closed this task as Resolved.Mar 18 2020, 02:42
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator