Page MenuHomeDevCentral
Create Task
Maniphest T1660

Rewrite Gulp builder code as module
Open, HighPublic
Actions

Description

gulp-imagemin 8 will require to use ES module syntax.

We can modernize builder script following:

Related Objects

Event Timeline

dereckson triaged this task as High priority.Sep 18 2021, 14:29
dereckson created this task.
dereckson renamed this task from Rewrite Gump builder code as module to Rewrite Gulp builder code as module.Sep 18 2021, 14:35
dereckson mentioned this in D2431: Document Python dependencies.Sep 18 2021, 14:51
dereckson mentioned this in D2432: Update dependencies.Sep 18 2021, 14:55
dereckson mentioned this in rUPSECTIONdbc7beac297e: Update dependencies.Sep 18 2021, 14:56
dereckson added a comment.Oct 3 2021, 20:52

If the goal is to avoid any security issue, gulp-imagemin last version still has a DoS regexp issue with trim-newline dependency.

dereckson added a comment.Sun, Nov 17, 00:17

As Node 22 supports require for ESM too, at least experimentally, we can also require Node 22+ instead.

dereckson moved this task from Backlog / triage to Gulp / template on the upsection board.Sun, Nov 17, 00:18
dereckson added a comment.Sun, Nov 17, 10:36

Some dependencies are loaded through ESM, like supports-color library directly for Node:

(node:25374) ExperimentalWarning: CommonJS module /opt/homebrew/lib/node_modules/npm/node_modules/debug/src/node.js is loading ES Module /opt/homebrew/lib/node_modules/npm/node_modules/supports-color/index.js using require().
Support for loading ES Module in require() is an experimental feature and might change at any time
dereckson added a comment.Sun, Nov 17, 11:50

In another hand, see also Gulp documentation: https://gulpjs.com/docs/en/getting-started/javascript-and-gulpfiles/

They recommend to install esm module to get import/export, instead of babel/@register.

Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator