Page MenuHomeDevCentral
Create Task
Maniphest T1870

Can't end network registration on Freenode
Closed, ResolvedPublic
Actions

Description

When the darkbot connects to IRC, it hangs after having sent USER and NICK.

Debug messages don't print full IRC output. For example, we receive the ** init messages, but not the CAP answers, or the 900 or 903 confirmation for SASL.

Timers work, for example every minute, it sends a ping.

This behavior has been confirmed on the following networks:

NetworkIRC server
Liberasolanum-1.0-dev
OFTCHybrid IRCd

It worked fine on Freenode in 2017 while darkbot source code hasn't changed, so it's something added those last years.

This issue means we can't use Odderon anymore.

Revisions and Commits

rDARKBOT Darkbot
D3095rDARKBOT829d0e0bda75 Don't declare mutable variables as static

Related Objects

Event Timeline

dereckson triaged this task as High priority.May 14 2023, 18:36
dereckson created this task.
dereckson mentioned this in T1739: Add SASL capability to Darkbot.
dereckson added a comment.EditedMay 14 2023, 19:23

I can repro while connecting to Libera through znc.

Hypothesis: it hangs when it receives a message it doesn't know how to handle.

dereckson added a comment.May 14 2023, 22:11

Back to version 6f6, I can't repro the issue, it connects correctly:

IN ::sodium.libera.chat NOTICE odderon1 :*** Notice -- SASL authentication to a NickServ account with a verified email address is required to connect from your current network. Please see https://libera.chat/guides/sasl for configuration assistance.

IN :ERROR :Closing Link: windriver.nasqueron.org (SASL authentication to a NickServ account with a verified email address is required to connect from your current network. Please see https://libera.chat/guides/sasl for configuration assistance.)

OUT: QUIT :Caught ERROR from irc.ipv4.libera.chat :(
dereckson added a comment.May 15 2023, 00:32

SASL patch tested in T1739 works fine:

Connecting to irc.ipv4.libera.chat:6667 ...
odderon has connected to erbium.libera.chat! [2627 pid]
dereckson added a revision: D3095: Don't declare mutable variables as static.May 15 2023, 16:37
dereckson closed this task as Resolved by committing rDARKBOT829d0e0bda75: Don't declare mutable variables as static.May 15 2023, 16:42
dereckson claimed this task.
dereckson added a commit: rDARKBOT829d0e0bda75: Don't declare mutable variables as static.
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator