Page MenuHomeDevCentral

Another strlen null Arcanist to fix
Closed, ResolvedPublic

Description

    Diff for 'lib/fontawesome/6.4.0/metadata/icon-families.json' with context
    is 4,813,418 bytes in length. Generally, source changes should not be
    this large. If the file is not a text file, you can mark it 'binary'.
    Mark this file as 'binary' and continue? [y/N] y


[2023-05-21 00:43:47] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=production, ref.master=b50a646a3f49, ref.production=78f29fb101bd)
  #0 PhutilErrorHandler::handleError(integer, string, string, integer) called at [<arcanist>/src/repository/api/ArcanistGitAPI.php:1028]
  #1 ArcanistGitAPI::getFileDataAtRevision(NULL, string) called at [<arcanist>/src/repository/api/ArcanistGitAPI.php:988]
  #2 ArcanistGitAPI::getOriginalFileData(NULL) called at [<arcanist>/src/parser/diff/ArcanistDiffChange.php:245]
  #3 ArcanistDiffChange::convertToBinaryChange(ArcanistGitAPI) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:927]
  #4 ArcanistDiffWorkflow::generateChanges() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:370]
  #5 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:427]
<<< [0] (+12,316) <exec> 12,316,416 us