Maniphest T2050

organization.member_invited GitHub event triggers a 500
Open, NormalPublic
Actions

Assigned To

None

Authored By

	dereckson
	Oct 8 2024, 22:23

Description

Should be handled as administrative event, ie an avent independent from a repository. Instead, we got a 500 error.

Payload example:

P361 organization. member_invited 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90

1	{ "action": "member_invited", "invitation": { "id": 57083161, "node_id": "OI_kwDOAFWIqs4DZwUZ", "login": "aceppaluni", "email": null, "role": "direct_member", "created_at": "2024-10-08T20:59:47.000+02:00", "failed_at": null, "failed_reason": null, "inviter": { "login": "dereckson", "id": 135563, "node_id": "MDQ6VXNlcjEzNTU2Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/135563?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dereckson", "html_url": "https://github.com/dereckson", "followers_url": "https://api.github.com/users/dereckson/followers", "following_url": "https://api.github.com/users/dereckson/following{/other_user}", "gists_url": "https://api.github.com/users/dereckson/gists{/gist_id}", "starred_url": "https://api.github.com/users/dereckson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dereckson/subscriptions", "organizations_url": "https://api.github.com/users/dereckson/orgs", "repos_url": "https://api.github.com/users/dereckson/repos", "events_url": "https://api.github.com/users/dereckson/events{/privacy}", "received_events_url": "https://api.github.com/users/dereckson/received_events", "type": "User", "site_admin": false }, "team_count": 1, "invitation_teams_url": "https://api.github.com/organizations/5605546/invitations/57083161/teams", "invitation_source": "member" }, "user": { "login": "aceppaluni", "id": 113948612, "node_id": "U_kgDOBsq3xA", "avatar_url": "https://avatars.githubusercontent.com/u/113948612?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aceppaluni", "html_url": "https://github.com/aceppaluni", "followers_url": "https://api.github.com/users/aceppaluni/followers", "following_url": "https://api.github.com/users/aceppaluni/following{/other_user}", "gists_url": "https://api.github.com/users/aceppaluni/gists{/gist_id}", "starred_url": "https://api.github.com/users/aceppaluni/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aceppaluni/subscriptions", "organizations_url": "https://api.github.com/users/aceppaluni/orgs", "repos_url": "https://api.github.com/users/aceppaluni/repos", "events_url": "https://api.github.com/users/aceppaluni/events{/privacy}", "received_events_url": "https://api.github.com/users/aceppaluni/received_events", "type": "User", "site_admin": false }, "organization": { "login": "nasqueron", "id": 5605546, "node_id": "MDEyOk9yZ2FuaXphdGlvbjU2MDU1NDY=", "url": "https://api.github.com/orgs/nasqueron", "repos_url": "https://api.github.com/orgs/nasqueron/repos", "events_url": "https://api.github.com/orgs/nasqueron/events", "hooks_url": "https://api.github.com/orgs/nasqueron/hooks", "issues_url": "https://api.github.com/orgs/nasqueron/issues", "members_url": "https://api.github.com/orgs/nasqueron/members{/member}", "public_members_url": "https://api.github.com/orgs/nasqueron/public_members{/member}", "avatar_url": "https://avatars.githubusercontent.com/u/5605546?v=4", "description": "Central hub of a budding community of creative people, writers, developers and thinkers." }, "sender": { "login": "dereckson", "id": 135563, "node_id": "MDQ6VXNlcjEzNTU2Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/135563?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dereckson", "html_url": "https://github.com/dereckson", "followers_url": "https://api.github.com/users/dereckson/followers", "following_url": "https://api.github.com/users/dereckson/following{/other_user}", "gists_url": "https://api.github.com/users/dereckson/gists{/gist_id}", "starred_url": "https://api.github.com/users/dereckson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dereckson/subscriptions", "organizations_url": "https://api.github.com/users/dereckson/orgs", "repos_url": "https://api.github.com/users/dereckson/repos", "events_url": "https://api.github.com/users/dereckson/events{/privacy}", "received_events_url": "https://api.github.com/users/dereckson/received_events", "type": "User", "site_admin": false } class="o">}

{ "action": "member_invited", "invitation": { "id": 57083161, "node_id": "OI_kwDOAFWIqs4DZwUZ", "login": "aceppaluni", "email": null, "role": "direct_member", "created_at": "2024-10-08T20:59:47.000+02:00", "failed_at": null, "failed_reason": null, "inviter": { "login": "dereckson", "id": 135563, "node_id": "MDQ6VXNlcjEzNTU2Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/135563?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dereckson", "html_url": "https://github.com/dereckson", "followers_url": "https://api.github.com/users/dereckson/followers", "following_url": "https://api.github.com/users/dereckson/following{/other_user}", "gists_url": "https://api.github.com/users/dereckson/gists{/gist_id}", "starred_url": "https://api.github.com/users/dereckson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dereckson/subscriptions", "organizations_url": "https://api.github.com/users/dereckson/orgs", "repos_url": "https://api.github.com/users/dereckson/repos", "events_url": "https://api.github.com/users/dereckson/events{/privacy}", "received_events_url": "https://api.github.com/users/dereckson/received_events", "type": "User", "site_admin": false }, "team_count": 1, "invitation_teams_url": "https://api.github.com/organizations/5605546/invitations/57083161/teams", "invitation_source": "member" }, "user": { "login": "aceppaluni", "id": 113948612, "node_id": "U_kgDOBsq3xA", "avatar_url": "https://avatars.githubusercontent.com/u/113948612?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aceppaluni", "html_url": "https://github.com/aceppaluni", "followers_url": "https://api.github.com/users/aceppaluni/followers", "following_url": "https://api.github.com/users/aceppaluni/following{/other_user}", "gists_url": "https://api.github.com/users/aceppaluni/gists{/gist_id}", "starred_url": "https://api.github.com/users/aceppaluni/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aceppaluni/subscriptions", "organizations_url": "https://api.github.com/users/aceppaluni/orgs", "repos_url": "https://api.github.com/users/aceppaluni/repos", "events_url": "https://api.github.com/users/aceppaluni/events{/privacy}", "received_events_url": "https://api.github.com/users/aceppaluni/received_events", "type": "User", "site_admin": false }, "organization": { "login": "nasqueron", "id": 5605546, "node_id": "MDEyOk9yZ2FuaXphdGlvbjU2MDU1NDY=", "url": "https://api.github.com/orgs/nasqueron", "repos_url": "https://api.github.com/orgs/nasqueron/repos", "events_url": "https://api.github.com/orgs/nasqueron/events", "hooks_url": "https://api.github.com/orgs/nasqueron/hooks", "issues_url": "https://api.github.com/orgs/nasqueron/issues", "members_url": "https://api.github.com/orgs/nasqueron/members{/member}", "public_members_url": "https://api.github.com/orgs/nasqueron/public_members{/member}", "avatar_url": "https://avatars.githubusercontent.com/u/5605546?v=4", "description": "Central hub of a budding community of creative people, writers, developers and thinkers." }, "sender": { "login": "dereckson", "id": 135563, "node_id": "MDQ6VXNlcjEzNTU2Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/135563?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dereckson", "html_url": "https://github.com/dereckson", "followers_url": "https://api.github.com/users/dereckson/followers", "following_url": "https://api.github.com/users/dereckson/following{/other_user}", "gists_url": "https://api.github.com/users/dereckson/gists{/gist_id}", "starred_url": "https://api.github.com/users/dereckson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dereckson/subscriptions", "organizations_url": "https://api.github.com/users/dereckson/orgs", "repos_url": "https://api.github.com/users/dereckson/repos", "events_url": "https://api.github.com/users/dereckson/events{/privacy}", "received_events_url": "https://api.github.com/users/dereckson/received_events", "type": "User", "site_admin": false } class="o">}

Exception:

As the event doesn't contain a repository, it triggers an error.

[2024-10-08 18:59:49] production.ERROR: ErrorException: Undefined property: stdClass::$repository in /var/wwwroot/default/app/Analyzers/GitHub/GitHubPayloadAnalyzer.php:84
Stack trace:
#0 /var/wwwroot/default/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(266): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(2, 'Undefined prope...', '/var/wwwroot/d
e...', 84)
#1 /var/wwwroot/default/app/Analyzers/GitHub/GitHubPayloadAnalyzer.php(84): Illuminate\Foundation\Bootstrap\HandleExceptions->Illuminate\Foundation\Bootstrap\{closure}(2, 'Undefined prope...', '/var/wwwroot/de...',
 84)
#2 /var/wwwroot/default/app/Analyzers/BasePayloadAnalyzer.php(164): Nasqueron\Notifications\Analyzers\GitHub\GitHubPayloadAnalyzer->getItemName()
#3 /var/wwwroot/default/app/Notifications/GitHubNotification.php(51): Nasqueron\Notifications\Analyzers\BasePayloadAnalyzer->getGroup()
#4 /var/wwwroot/default/app/Notifications/GitHubNotification.php(26): Nasqueron\Notifications\Notifications\GitHubNotification->getGroup()
#5 /var/wwwroot/default/app/Jobs/FireGitHubNotification.php(41): Nasqueron\Notifications\Notifications\GitHubNotification->__construct('Nasqueron', 'organization', Object(stdClass))

Revisions and Commits

rNOTIF Notifications center
	Draft	D3500 Handle organization and projects_v2 GitHub events

Related Objects

Mentioned Here: P361 organization. member_invited payload

Event Timeline

dereckson triaged this task as Normal priority.Oct 8 2024, 22:23

dereckson created this task.

The same issue is triggered by projects_v2, again because there is no repository.

This issue IS NOT triggered for ping and membership, as those are declared as administrative events.

A fix could be to add organization and projects_v2 in that list:
https://devcentral.nasqueron.org/source/notifications/browse/main/app/Analyzers/GitHub/GitHubPayloadAnalyzer.php$91

dereckson added a revision: D3500: Handle organization and projects_v2 GitHub events.Oct 8 2024, 22:43

organization.member_invited GitHub event triggers a 500Open, NormalPublicActions

Description

Revisions and Commits

Related Objects

Event Timeline

organization.member_invited GitHub event triggers a 500
Open, NormalPublic
Actions