Page MenuHomeDevCentral

Update phpcs codestyle for Nasqueron
Closed, ResolvedPublic

Description

We need to update the phpcs standard in codestyle repository.


arc lint will block as return code is non-zero:

$ arc lint
    - CommandException: Command failed with error #1!
      COMMAND
      vendor/bin/phpcs '--report=xml' '--standard=phpcs.xml' /datacube/dereckson/dev/nasqueron/keruald/keruald/omnitools/src/DataTypes/Result/Ok.php
      
      STDOUT
      WARNING: The Nasqueron standard uses 2 deprecated sniffs
      --------------------------------------------------------------------------------
      -  Generic.Formatting.NoSpaceAfterCast
         This sniff has been deprecated since v3.4.0 and will be removed in v4.0.0.
         Use the Generic.Formatting.SpaceAfterCast sniff with the $spacing property
         set to 0 instead.
      -  Generic.Functions.CallTimePassByReference
         This sniff has been deprecated since v3.12.1 and will be removed in v4.0.0.
      
      Deprecated sniffs are still run, but will stop working at some point in the
      future.
      
      <?xml version="1.0" encoding="UTF-8"?>
      <phpcs version="3.13.5">
      <file name="/datacube/dereckson/dev/nasqueron/keruald/keruald/omnitools/src/DataTypes/Result/Ok.php" errors="0" warnings="2" fixable="0">
          <warning line="56" column="12" source="Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass" severity="5" fixable="0">The method parameter $callable is never used</warning>
          <warning line="60" column="12" source="G... (162 more byte(s)) ...

Codestyle is used and should be bumped:

Event Timeline

dereckson triaged this task as High priority.Sun, Oct 12, 13:09
dereckson created this task.
dereckson moved this task from Backlog to Debt on the Keruald board.
dereckson moved this task from Backlog to Debt on the Notifications center board.
dereckson moved this task from Backlog to Blocked on dev on the Mediawiki SaaS board.
dereckson moved this task from Backlog to Next on the Development tools board.

New package release: nasqueron/codestyle v0.1.2

dereckson claimed this task.
dereckson updated the task description. (Show Details)