Page MenuHomeDevCentral
Create Task
Maniphest T307

Book template can't be generated if there is no publisher on Worldcat
Closed, ResolvedPublic
Actions

Description

When fetching the template for a book, OCLC machine-readable data doesn't contain expected publisher information.

Fatal error: Call to a member function get() on null in /var/wwwroot/nasqueron.org/tools/wikimedia/write/sourcetemplatesgenerator/book.php on line 20

$book->get('schema:publisher')->get('schema:name');

How to reproduce?

Revisions and Commits

rSTG Source templates generator
rSTG4705814cad05 OCLC machine-readable data parsing is now more fault tolerant

Related Objects

Event Timeline

dereckson created this task.Apr 5 2015, 12:15
dereckson claimed this task.
dereckson raised the priority of this task from to High.
dereckson updated the task description. (Show Details)
dereckson added a project: Source templates generator.
dereckson added a subscriber: dereckson.
dereckson updated the task description. (Show Details)Apr 5 2015, 12:18
dereckson closed this task as Resolved.Apr 5 2015, 12:25
dereckson added a commit: rSTG4705814cad05: OCLC machine-readable data parsing is now more fault tolerant.

Closed by commit rSTG4705814cad05.

dereckson added a comment.Apr 5 2015, 12:32

Change has been deployed live on http://tools.nasqueron.org/wikimedia/write/sourcetemplatesgenerator/.

$ cd /home/wwwroot/nasqueron.org/tools
$ make clean all
rm -rf vendor composer.lock wikimedia/write/sourcetemplatesgenerator
composer install
Loading composer repositories with package information
Installing dependencies (including require-dev)
  - Installing easyrdf/easyrdf (0.9.1)
    Loading from cache

  - Installing dereckson/source-templates-generator (dev-master 4705814)
    Cloning 4705814cad0539a06a81e1fd90a101c302ad4bea

easyrdf/easyrdf suggests installing ml/json-ld (~1.0)
Writing lock file
Generating autoload files
mv vendor/dereckson/source-templates-generator wikimedia/write/sourcetemplatesgenerator
dereckson moved this task from Backlog to Deployed on tools. on the Source templates generator board.Jul 26 2015, 15:31
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator