Page MenuHomeDevCentral

Address ProjectsMap::isCached visibility
Closed, ResolvedPublic

Description

rNOTIF73d3e926e543 mofiied the visibility of ProjectsMap::isCached.

We should revert to a public method, or delete the method.

$ ant phpmd
Buildfile: /home/ubuntu/workspace/notifications/build.xml

phpmd:
    [phpmd] 
    [phpmd] /home/ubuntu/workspace/notifications/app/Phabricator/ProjectsMap.php:186    Avoid unused private methods such as 'isCached'.
    [phpmd] Result: 2

BUILD SUCCESSFUL
Total time: 3 seconds

Event Timeline

The method can be public.

Use case

A console command to show the application configuration.

$ php artisan config:show
+-------------+-----------+---------------------------------+--------------------------+
| Gate        | Door      | Instance                        | Status                   |
+-------------+-----------+---------------------------------+--------------------------+
| GitHub      | Nasqueron | ø                               | ✓                        |
| Phabricator | Nasqueron | http://devcentral.nasqueron.org | Projects map not cached. |
+-------------+-----------+---------------------------------+--------------------------+
$ php artisan phabricator:projectsmap
$ php artisan config:show
+-------------+-----------+---------------------------------+--------+
| Gate        | Door      | Instance                        | Status |
+-------------+-----------+---------------------------------+--------+
| GitHub      | Nasqueron | ø                               | ✓      |
| Phabricator | Nasqueron | http://devcentral.nasqueron.org | ✓      |
+-------------+-----------+---------------------------------+--------+