Differential D3880

Avoid notices in database tests
ClosedPublic
Actions

Authored by dereckson on Tue, Nov 11, 18:08.

Details

Reviewers

dereckson

Maniphest Tasks

T2188: Fix tests for PHPUnit 12

Commits

rKDBdb0b20fcbf9c: Avoid notices in database tests
rKERUALDba7ec81ee0d3: Avoid notices in database tests

Summary

This fixes the following issue:

notice when trying to read "errno" key
PHPUnit notice and "N" test status, when using createMock but not calling expect

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Errors

Severity	Location	Code	Message
Error	database/tests/Exceptions/SqlExceptionTest.php:29	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded

Unit

Test Failures

Branch

main

Build Status

Buildable 6183
Build 6467: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/home/dereckson/dev/keruald/_monorepo/core/database/tests/Exceptions/SqlExceptionTest.php
	0 ms	/home/dereckson/dev/keruald/_monorepo/core/database/tests/Query/PDOQueryTest.php

Event Timeline

dereckson created this revision.Tue, Nov 11, 18:08

Harbormaster completed remote builds in B6183: Diff 10046.Tue, Nov 11, 18:08

dereckson requested review of this revision.Tue, Nov 11, 18:08

dereckson accepted this revision.Tue, Nov 11, 18:09

This revision is now accepted and ready to land.Tue, Nov 11, 18:09

dereckson edited the summary of this revision. (Show Details)Tue, Nov 11, 18:09

This revision was landed with ongoing or failed builds.Tue, Nov 11, 18:10

Closed by commit rKERUALDba7ec81ee0d3: Avoid notices in database tests (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALDba7ec81ee0d3: Avoid notices in database tests.

dereckson added a commit: rKDBdb0b20fcbf9c: Avoid notices in database tests.

dereckson added a task: T2188: Fix tests for PHPUnit 12.Tue, Nov 11, 18:38

Revision Contents
Changeset List

Path

Size

database/

tests/

Exceptions/

SqlExceptionTest.php

10 lines

Query/

PDOQueryTest.php

4 lines

Diff 10046

View Options

database/tests/Exceptions/SqlExceptionTest.php