WIP: move get_current_url() and co in OmniTools Request class
Changes PlannedPublic
Actions

Authored by dereckson on Tue, Nov 11, 18:13.

Tags

None

Referenced Files

	F12758602: D3881.id.diff
	Fri, Nov 14, 18:02

	Unknown Object (File)
	Thu, Nov 13, 20:26

	Unknown Object (File)
	Thu, Nov 13, 20:26

	Unknown Object (File)
	Thu, Nov 13, 20:24

	Unknown Object (File)
	Thu, Nov 13, 20:24

	Unknown Object (File)
	Thu, Nov 13, 20:23

	Unknown Object (File)
	Thu, Nov 13, 20:23

	Unknown Object (File)
	Thu, Nov 13, 16:03

View All 14 Files

Subscribers

None

Details

Reviewers: None

Test Plan

This code has been battle-tested with several sites using:

direct .php access in the URL
Apache + mod_rewrite
nginx try_files directive

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Passed

Unit

Test Failures

Branch

request-current-url

Build Status

Buildable 6184
Build 6468: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/datacube/dereckson/dev/nasqueron/keruald/keruald/omnitools/tests/HTTP/Requests/RequestTest.php

Event Timeline

dereckson requested review of this revision.Tue, Nov 11, 18:13

dereckson created this revision.

Harbormaster completed remote builds in B6184: Diff 10049.Tue, Nov 11, 18:13

Unit tests still to commit

Revision Contents
Changeset List

Path

Size

omnitools/

src/

HTTP/

Requests/

Request.php

1 line

WithLocalURL.php

141 lines

Diff 10049

View Options

omnitools/src/HTTP/Requests/Request.php