This terminator plugin uses resolve-hash module
to solve then redirects to specified commit.
Ref T1695.
Details
Details
- Reviewers
dereckson - Maniphest Tasks
- T1695: Write a Terminator plugin to resolve hashes
Diff Detail
Diff Detail
- Repository
- rRESOLVEHASH Resolve hash
- Lint
Lint Skipped - Unit
No Test Coverage - Branch
- terminator-plugin
- Build Status
Buildable 6372 Build 6656: arc lint + arc unit
Event Timeline
Comment Actions
Repository move
@Duranzed Can you try to recreate the commit on a branch on the top of resolve-hash main and try this command?
arc diff --update D3976 HEAD^ -m 'Moving to resolve-hash repository'
Comment Actions
Updated hash resolver plugin for terminator :
- Intégration native de resolve-hash
- Optimisation des performances
- Gestion des erreurs
Comment Actions
Plugin works, but we need more metadata:
- header on the Python file
- explanation in the README how to install it
| support/terminator/resolve_hash.py | ||
|---|---|---|
| 2 | Header is missing. I'd suggest something like # ------------------------------------------------------------- # Resolve hash # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - # Project: Nasqueron # Description: Terminator plugin to call Resolve hash as # URL handler for longer hashes # License: BSD-2-Clause # ------------------------------------------------------------- | |
Comment Actions
Added README.md file for installation steps
Added Nasqueron header in the plugin file
Comment Actions
Plugin works, but now we need to polish the two README files.
| support/terminator/README.md | ||
|---|---|---|
| 2 | I'd really like the main README to link to that one too. | |
Comment Actions
An issue we noticed during proofreading the README and testing installation procedure is terminator runs python3 -sP.
The -s matches "Don't add user site directory to sys.path." and blocks the resolvehash module loading:
PluginRegistry::load_plugins: Importing plugin resolve_hash.py failed: No module named 'resolvehash'