Page MenuHomeDevCentral

Add plugin for terminator to resolve hashes
Needs ReviewPublic

Authored by Duranzed on Mon, Feb 23, 16:23.
Tags
None
Referenced Files
F24679840: D3976.id10323.diff
Wed, Mar 4, 21:06
F24678733: D3976.id10323.diff
Wed, Mar 4, 19:20
F24673004: D3976.id10321.diff
Wed, Mar 4, 12:21
F24670832: D3976.id10323.diff
Wed, Mar 4, 09:45
F24670831: D3976.id10322.diff
Wed, Mar 4, 09:45
F24670829: D3976.id10321.diff
Wed, Mar 4, 09:45
F24670826: D3976.id10315.diff
Wed, Mar 4, 09:44
F24670825: D3976.id10309.diff
Wed, Mar 4, 09:44
Subscribers
None
Tokens
"Like" token, awarded by dereckson.

Details

Summary

This terminator plugin uses resolve-hash module
to solve then redirects to specified commit.

Ref T1695.

Diff Detail

Repository
rRESOLVEHASH Resolve hash
Lint
Lint Passed
Unit
No Test Coverage
Branch
terminator-plugin
Build Status
Buildable 6420
Build 6704: arc lint + arc unit

Event Timeline

Duranzed created this revision.

Not for the operations repository, it's for rRESOLVEHASH.

Repository move

@Duranzed Can you try to recreate the commit on a branch on the top of resolve-hash main and try this command?

arc diff --update D3976 HEAD^ -m 'Moving to resolve-hash repository'

dereckson requested changes to this revision.Mon, Feb 23, 17:57
This revision now requires changes to proceed.Mon, Feb 23, 17:57

Moving to resolve-hash repository

Moving to resolve-hash repository

Updated hash resolver plugin for terminator :

  • Intégration native de resolve-hash
  • Optimisation des performances
  • Gestion des erreurs

Plugin works, but we need more metadata:

  • header on the Python file
  • explanation in the README how to install it
support/terminator/resolve_hash.py
2

Header is missing.

I'd suggest something like

#   -------------------------------------------------------------
#   Resolve hash
#   - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
#   Project:        Nasqueron
#   Description:    Terminator plugin to call Resolve hash as
#                   URL handler for longer hashes
#   License:        BSD-2-Clause
#   -------------------------------------------------------------
dereckson requested changes to this revision.Wed, Feb 25, 23:42
This revision now requires changes to proceed.Wed, Feb 25, 23:42

Added README.md file for installation steps
Added Nasqueron header in the plugin file

Duranzed marked an inline comment as done.

Removed unused imports

dereckson requested changes to this revision.Wed, Mar 4, 07:31

Plugin works, but now we need to polish the two README files.

support/terminator/README.md
2

I'd really like the main README to link to that one too.

This revision now requires changes to proceed.Wed, Mar 4, 07:31