This is a follow-up for 7d91908d.
Details
Details
Diff Detail
Diff Detail
- Repository
- rOPS Nasqueron Operations
- Lint
Lint Warnings Severity Location Code Message Warning roles/salt-primary/software/files/autochmod-git.sh:46 SC2046 SHELLCHECK Warning roles/salt-primary/software/files/autochmod-git.sh:47 SC2046 SHELLCHECK Advice roles/salt-primary/software/files/autochmod-git.sh:45 SC2086 SHELLCHECK - Unit
No Test Coverage - Branch
- autochmod-git-update
- Build Status
Buildable 6431 Build 6715: arc lint + arc unit
Event Timeline
Comment Actions
About shellcheck linter issues.
As documented in the commit message, we trade whitespace security to straightforward convenience knowing we don't use space in file names.
As such, we want to use space for word splitting in the output of find command, space is a valid separator between files in our repository.
Comment Actions
I've discovered X option in chmod that solves the issue nicely, by setting executable bit only where needed (already executable files and directories), so we can keep the find approach and stay safe for whitespaces.