Read the CARP peer parameter from pillar
ClosedPublic
Actions

Authored by yousra on Wed, Mar 18, 13:35.

Details

Reviewers

dereckson
Duranzed

Maniphest Tasks

T2274: Configure CARP to send advertisements in unicast mode

Commits

rOPSdf4a2c0fb05f: Read the CARP peer parameter from pillar

Summary

Parameter is optional.

Ref T2274

Test Plan

Tested the function (get_carp_entries) with CARP entries containing a peer

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Skipped

Unit

No Test Coverage

Branch

test-node.py-peer

Build Status

Buildable 6492
Build 6776: arc lint + arc unit

Event Timeline

yousra requested review of this revision.Wed, Mar 18, 13:35

yousra created this revision.

Harbormaster completed remote builds in B6492: Diff 10463.Wed, Mar 18, 13:35

yousra mentioned this in T2274: Configure CARP to send advertisements in unicast mode.Wed, Mar 18, 15:03

dereckson retitled this revision from Update get_carp_entries in _modules/node.py to read the optional CARP peer parameter from pillar to Read the CARP peer parameter from pillar.Wed, Mar 18, 19:38

dereckson edited the summary of this revision. (Show Details)

dereckson added inline comments.Wed, Mar 18, 19:42

_modules/node.py
523
537	Can be simplified in Python 3.8+: if peer := fhrp.get("peer"): entry["peer"] = peer Reference: https://docs.python.org/3/whatsnew/3.8.html#assignment-expressions