Page MenuHomeDevCentral

Read the CARP peer parameter from pillar
ClosedPublic

Authored by yousra on Mar 18 2026, 13:35.
Tags
None
Referenced Files
F27277368: D4009.id10463.diff
Sat, May 2, 20:18
Unknown Object (File)
Mon, Apr 27, 01:03
Unknown Object (File)
Wed, Apr 22, 07:22
Unknown Object (File)
Tue, Apr 21, 18:04
Unknown Object (File)
Sun, Apr 19, 21:03
Unknown Object (File)
Sat, Apr 18, 08:02
Unknown Object (File)
Tue, Apr 14, 13:05
Unknown Object (File)
Sun, Apr 12, 18:44

Details

Summary

Parameter is optional.

Ref T2274

Test Plan

Tested the function (get_carp_entries) with CARP entries containing a peer

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Skipped
Unit
No Test Coverage
Branch
test-node.py-peer
Build Status
Buildable 6492
Build 6776: arc lint + arc unit

Event Timeline

yousra requested review of this revision.Mar 18 2026, 13:35
yousra created this revision.
dereckson retitled this revision from Update get_carp_entries in _modules/node.py to read the optional CARP peer parameter from pillar to Read the CARP peer parameter from pillar.Mar 18 2026, 19:38
dereckson edited the summary of this revision. (Show Details)
_modules/node.py
523
537

Can be simplified in Python 3.8+:

if peer := fhrp.get("peer"):
    entry["peer"] = peer

Reference: https://docs.python.org/3/whatsnew/3.8.html#assignment-expressions

Simplified in Python 3.8+ :

if peer := fhrp.get("peer"):

entry["peer"] = peer
This revision is now accepted and ready to land.Mar 19 2026, 18:09
This revision was automatically updated to reflect the committed changes.