Paths

Table of Contentst

Differential D4028

Update Black style
Needs ReviewPublic
Actions

Authored by dereckson on Tue, Mar 24, 12:48.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 12, 21:32

	Unknown Object (File)
	Sun, Apr 12, 17:39

	Unknown Object (File)
	Sun, Apr 12, 01:57

	Unknown Object (File)
	Wed, Apr 8, 00:12

	Unknown Object (File)
	Sun, Apr 5, 09:50

	Unknown Object (File)
	Sat, Apr 4, 07:08

	Unknown Object (File)
	Fri, Apr 3, 08:45

	Unknown Object (File)
	Fri, Apr 3, 04:40

View All 49 Files

Subscribers

None

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

Black 26 enforces the number of blank lines for imports.

The goal was to ensure one was added, but it has the side effect
to remove one line when the "import" keyword is encountered.

Nasqueron style put 2 by coherence with functions separators.

This change does two things to create a new coherent Black-compliant style:

Apply Black 26
Remove extra lines added previously to have a rhythm of 2 2 to 1 1

Test Plan

black

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Errors

Severity	Location	Code	Message
Error	_modules/node.py:500	E501	flake8 E501
Error	_modules/node.py:527	E501	flake8 E501
Error	_modules/node.py:534	E501	flake8 E501
Error	_modules/rabbitmq_api.py:61	E501	flake8 E501
Error	_tests/pillar/dbserver/test_postgresql.py:69	E501	flake8 E501
Error	roles/core/certificates/files/certbot/utilities/check-letsencrypt-certificates.py:11	E501	flake8 E501
Error	roles/dbserver-pgsql/monitoring/files/check-postgresql-dependencies.py:60	E501	flake8 E501
Error	roles/dbserver-pgsql/monitoring/files/check-postgresql-xml-support.py:52	E501	flake8 E501
Error	roles/devserver/webserver-home/files/setup-web-home.py:53	E501	flake8 E501
Error	roles/mailserver/postfix/files/postfix-to-mailman.py:21	E501	flake8 E501
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:117	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:215	E501	flake8 E501
Error	roles/paas-docker/docker/files/docker-paas-list-containers.py:63	E501	flake8 E501
Error	utils/dump-py-state.py:64	E501	flake8 E501
Error	utils/netbox/document-hypervisors.py:160	E501	flake8 E501
Error	utils/vault/wordpress-provision-secrets.py:104	E501	flake8 E501
Error	utils/vault/wordpress-provision-secrets.py:115	E501	flake8 E501

Unit

No Test Coverage

Branch

configure-docker-upstreams

Build Status

Buildable 6538
Build 6822: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Tue, Mar 24, 12:48

dereckson created this revision.

Harbormaster completed remote builds in B6538: Diff 10525.Tue, Mar 24, 12:48

Revision Contents
Changeset List

Path

Size

_modules/

2 lines

1 line

network_utils.py

2 lines

2 lines

rabbitmq_api.py

2 lines

_states/

2 lines

_tests/

2 lines

modules/

1 line

pillar/

core/

1 line

credentials/

1 line

dbserver/

test_postgresql.py

2 lines

paas/

1 line

roles/

python/

dns/

test_dns_zones.py

2 lines

scripts/

python/

test_clear_video_queue.py

1 line

test_edit_acme_dns_accounts.py

2 lines

roles/

core/

certificates/

files/

certbot/

utilities/

check-letsencrypt-certificates.py

2 lines

dbserver-pgsql/

monitoring/

files/

check-postgresql-dependencies.py

2 lines

check-postgresql-xml-support.py

2 lines

devserver/

api-exec/

files/

2 lines

userland-software/

files/

ccache-metrics.py

5 lines

install-clang-format-alias.py

2 lines

1 line

2 lines

webserver-home/

files/

setup-web-home.py

2 lines

mailserver/

postfix/

files/

postfix-to-mailman.py

2 lines

monitoring/

checks/

files/

check-github-storage.py

3 lines

paas-docker/

containers/

files/

hound/

generate-config.py

3 lines

mastodon/

clear-video-queue.py

2 lines

sentry/

etc/

2 lines

docker/

files/

docker-paas-list-containers.py

3 lines

utils/

dump-py-state.py

2 lines

migrate-ssh-keys.py

2 lines

netbox/

build-etc-hosts-drake.py

3 lines

document-hypervisors.py

3 lines

1 line

nginx/

2 lines

show-local-states.py

2 lines

templates/

3 lines

vault/

issue-admin-token.py

2 lines

wordpress-provision-secrets.py

2 lines

Diff 10525

_modules/convert.py

Loading...

_modules/credentials.py

Loading...

_modules/network_utils.py

Loading...

_modules/node.py

Loading...

_modules/rabbitmq_api.py

Loading...

_states/rabbitmq.py

Loading...

_tests/helpers.py

Loading...

_tests/modules/test_nano.py

Loading...

_tests/pillar/core/test_users.py

Loading...

_tests/pillar/credentials/test_vault.py

Loading...

_tests/pillar/dbserver/test_postgresql.py

Loading...

_tests/pillar/paas/test_docker.py

Loading...

_tests/roles/python/dns/test_dns_zones.py

Loading...

_tests/scripts/python/test_clear_video_queue.py

Loading...

_tests/scripts/python/test_edit_acme_dns_accounts.py

Loading...

roles/core/certificates/files/certbot/utilities/check-letsencrypt-certificates.py

Loading...

roles/dbserver-pgsql/monitoring/files/check-postgresql-dependencies.py

Loading...

roles/dbserver-pgsql/monitoring/files/check-postgresql-xml-support.py

Loading...

roles/devserver/api-exec/files/server.py

Loading...

roles/devserver/userland-software/files/ccache-metrics.py

Loading...

roles/devserver/userland-software/files/install-clang-format-alias.py

Loading...

roles/devserver/userland-software/files/shell.py

Loading...

roles/devserver/userland-software/files/url.py

Loading...

roles/devserver/webserver-home/files/setup-web-home.py

Loading...

roles/mailserver/postfix/files/postfix-to-mailman.py

Loading...

roles/monitoring/checks/files/check-github-storage.py

Loading...

roles/paas-docker/containers/files/hound/generate-config.py

Loading...

roles/paas-docker/containers/files/mastodon/clear-video-queue.py

Loading...

roles/paas-docker/containers/files/sentry/etc/sentry.conf.py

Loading...

roles/paas-docker/docker/files/docker-paas-list-containers.py

Loading...

utils/dump-py-state.py

Loading...

utils/migrate-ssh-keys.py

Loading...

utils/netbox/build-etc-hosts-drake.py

Loading...

utils/netbox/document-hypervisors.py

Loading...

utils/next-uid.py

Loading...

utils/nginx/ranges2geo.py

Loading...

utils/show-local-states.py

Loading...

utils/templates/create.py

Loading...

utils/vault/issue-admin-token.py

Loading...

utils/vault/wordpress-provision-secrets.py

Loading...