Differential D4046

Normalize quotes
Needs ReviewPublic
Actions

Authored by dereckson on Fri, Apr 3, 22:50.

Tags

None

Referenced Files

	F25197131: D4046.id10562.diff
	Sat, Apr 4, 12:37

	F25197112: D4046.largetrue.diff
	Sat, Apr 4, 12:35

	F25194150: D4046.diff
	Sat, Apr 4, 09:28

	F25194024: D4046.diff
	Sat, Apr 4, 09:21

Subscribers

None

Details

Reviewers

Summary

A lot of Jinja, Python and Salt expressions uses single quotes.

As other language code conventions tend to switch to double quotes,
it's a good move to respect principle of less surprise and to be coherent
to use double quotes in this repository too.

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Errors

Severity	Location	Code	Message
Error	roles/viperserv/eggdrop/cron.sls:16	E111	flake8 E111
Error	roles/viperserv/eggdrop/cron.sls:19	E111	flake8 E111
Error	roles/viperserv/eggdrop/cron.sls:55	E501	flake8 E501

Unit

No Test Coverage

Branch

normalize-quotes

Build Status

Buildable 6570
Build 6854: arc lint + arc unit

Event Timeline

dereckson created this revision.Fri, Apr 3, 22:50

This change touches Wolfplex files. As such, administrative approval is needed from Wolfplex technical contact.

dereckson requested review of this revision.Fri, Apr 3, 22:50

Harbormaster completed remote builds in B6570: Diff 10562.Fri, Apr 3, 22:50

Large Diff

This large diff affects 197 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

_modules/

2 lines

hotfixes/

CVE-2017-6074.sls

4 lines

2 lines

T1261-srv-data.sls

2 lines

T1345-drop-jails-from-ysul.sls

4 lines

leap-seconds.sls

2 lines

old-directories.sls

2 lines

2 lines

2 lines

426 lines

pillar/

credentials/

2 lines

roles/

bastion/

pam/

2 lines

sshd-otp/

4 lines

2 lines

yubico/

authorized_yubikeys.sls

6 lines

2 lines

2 lines

core/

certificates/

letsencrypt.sls

2 lines

hostname/

4 lines

login/

6 lines

memory/

2 lines

motd/

12 lines

network/

files/

ipv6-tunnels/

eglide.sh.jinja

2 lines

4 lines

10 lines

6 lines

22 lines

4 lines

ipv6_tunnel.sls

6 lines

20 lines

4 lines

rc/

6 lines

rsyslog/

2 lines

salt/

8 lines

src/

4 lines

sshd/

files/

2 lines

4 lines

storage/

2 lines

sudo/

2 lines

sysctl/

6 lines

timezone/

6 lines

userland-home/

6 lines

userland-software/

14 lines

12 lines

6 lines

users/

26 lines

dbserver-mysql/

content/

4 lines

mysql-server/

8 lines

6 lines

dbserver-pgsql/

server/

4 lines

2 lines

devserver/

api-exec/

2 lines

datacube/

2 lines

mail/

2 lines

pkg/

2 lines

userland-home/

18 lines

10 lines

userland-software/

2 lines

files/

notifications.conf

2 lines

6 lines

20 lines

10 lines

notifications.sls

2 lines

12 lines

webserver-wwwroot51/

20 lines

dns/

knot/

2 lines

freebsd-repo/

4 lines

grafana/

grafana/

2 lines

mailserver/

dkim/

2 lines

dovecot/

2 lines

2 lines

28 lines

vimbadmin/

2 lines

opensearch/

dashboards/

6 lines

2 lines

opensearch/

10 lines

files/

internal_users.yml.jinja

8 lines

opensearch.conf

8 lines

tlsconfig.yml.jinja

14 lines

2 lines

10 lines

2 lines

14 lines

8 lines

paas-docker/

containers/

12 lines

12 lines

6 lines

api-datasources.sls

6 lines

14 lines

16 lines

12 lines

20 lines

docker-registry-api.sls

8 lines

10 lines

20 lines

files/

_tomcat/

tomcat-users.xml

2 lines

8 lines

10 lines

2 lines

14 lines

jenkins_agent.sls

16 lines

10 lines

mastodon_sidekiq.sls

2 lines

10 lines

12 lines

notifications.sls

28 lines

16 lines

8 lines

penpot_exporter.sls

2 lines

2 lines

phabricator.sls

34 lines

6 lines

34 lines

22 lines

16 lines

10 lines

6 lines

8 lines

10 lines

2 lines

symbolicator.sls

6 lines

8 lines

12 lines

docker/

4 lines

2 lines

2 lines

2 lines

2 lines

kernel/

4 lines

monitoring/

4 lines

nginx/

16 lines

files/

vhosts/

4 lines

2 lines

phabricator.conf

16 lines

2 lines

2 lines

2 lines

2 lines

2 lines

systemd-unit/

4 lines

wrappers/

8 lines

wwwroot-502/

2 lines

wwwroot-content/

4 lines

2 lines

paas-jails/

jails/

6 lines

paas-lxc/

lxc/

2 lines

prometheus/

prometheus/

2 lines

redis/

server/

2 lines

router/

carp/

files/

4 lines

4 lines

saas-mediawiki/

data/

2 lines

mediawiki/

2 lines

2 lines

4 lines

nginx/

2 lines

software/

6 lines

salt-primary/

account/

2 lines

service/

2 lines

shellserver/

odderon/

2 lines

quassel-core/

changepassword.sls

2 lines

16 lines

2 lines

userland-software/

30 lines

6 lines

vault/

4 lines

vhosts/

2 lines

web-hosting/

4 lines

vault/

policies/

6 lines

vault/

6 lines

viperserv/

account/

12 lines

eggdrop/

34 lines

8 lines

10 lines

2 lines

fantoir/

6 lines

rabbitmq-tcl/

2 lines

wikidata-access-layer/

2 lines

webserver-alkane/

account/

16 lines

alkane/

2 lines

directories/

4 lines

php/

10 lines

files/

php-fpm-pool.conf

2 lines

36 lines

4 lines

8 lines

webserver-content/

org/

eglide/

2 lines

nasqueron/

2 lines

wolfplex/

2 lines

space/

hypership/

2 lines

webserver-core/

nginx/

2 lines

webserver-legacy/

jenkins-cd/

2 lines

php-sites/

10 lines

files/

php-fpm-pool.conf

2 lines

26 lines

6 lines

static-sites/

4 lines

tweaks/

2 lines

Diff 10562

_modules/paas_docker.py

hotfixes/CVE-2017-6074.sls

hotfixes/MariaDB.sls

hotfixes/T1261-srv-data.sls

hotfixes/T1345-drop-jails-from-ysul.sls

hotfixes/leap-seconds.sls

hotfixes/old-directories.sls

hotfixes/python3.sls

hotfixes/salt.sls

map.jinja

pillar/credentials/vault.sls

roles/bastion/pam/init.sls

roles/bastion/sshd-otp/service.sls

roles/bastion/sshd-otp/software.sls

roles/bastion/yubico/authorized_yubikeys.sls

roles/bastion/yubico/pam.sls

roles/bastion/yubico/selinux.sls

roles/core/certificates/letsencrypt.sls

roles/core/hostname/init.sls

roles/core/login/init.sls

roles/core/memory/init.sls

roles/core/motd/init.sls

roles/core/network/files/ipv6-tunnels/eglide.sh.jinja

roles/core/network/files/ipv6-tunnels/ysul.sh.jinja

roles/core/network/gre.sls

roles/core/network/ipv4.sls

roles/core/network/ipv6.sls

roles/core/network/ipv6_fixes.sls

roles/core/network/ipv6_tunnel.sls

roles/core/network/map.jinja

roles/core/network/routes.sls

roles/core/rc/init.sls

roles/core/rsyslog/init.sls

roles/core/salt/init.sls

roles/core/src/init.sls

roles/core/sshd/files/sshd_config

roles/core/sshd/init.sls

roles/core/storage/snapshots.sls

roles/core/sudo/init.sls

roles/core/sysctl/init.sls

roles/core/timezone/init.sls

roles/core/userland-home/init.sls

roles/core/userland-software/base.sls

roles/core/userland-software/sources.sls

roles/core/userland-software/starship.sls

roles/core/users/init.sls

roles/dbserver-mysql/content/init.sls

roles/dbserver-mysql/mysql-server/cnf.sls

roles/dbserver-mysql/mysql-server/zfs.sls

roles/dbserver-pgsql/server/content.sls

roles/dbserver-pgsql/server/service.sls

roles/devserver/api-exec/config.sls

roles/devserver/datacube/init.sls

roles/devserver/mail/init.sls

roles/devserver/pkg/init.sls

roles/devserver/userland-home/homefiles.sls

roles/devserver/userland-home/repos.sls

roles/devserver/userland-software/dev.sls

roles/devserver/userland-software/files/notifications.conf

roles/devserver/userland-software/files/port_options

roles/devserver/userland-software/map.jinja

roles/devserver/userland-software/misc.sls

roles/devserver/userland-software/notifications.sls

roles/devserver/userland-software/ports.sls

roles/devserver/webserver-wwwroot51/sites.sls

roles/dns/knot/config.sls

roles/freebsd-repo/map.jinja

roles/grafana/grafana/init.sls

roles/mailserver/dkim/software.sls

roles/mailserver/dovecot/config.sls

roles/mailserver/dovecot/software.sls

roles/mailserver/map.jinja

roles/mailserver/vimbadmin/config.sls

roles/opensearch/dashboards/config.sls

roles/opensearch/dashboards/service.sls

roles/opensearch/opensearch/config.sls

roles/opensearch/opensearch/files/internal_users.yml.jinja

roles/opensearch/opensearch/files/opensearch.conf

roles/opensearch/opensearch/files/tlsconfig.yml.jinja

roles/opensearch/opensearch/kernel.sls

roles/opensearch/opensearch/security.sls

roles/opensearch/opensearch/service.sls

roles/opensearch/opensearch/software.sls

roles/opensearch/opensearch/wrapper.sls

roles/paas-docker/containers/acme_dns.sls

roles/paas-docker/containers/airflow.sls

roles/paas-docker/containers/aphlict.sls

roles/paas-docker/containers/api-datasources.sls

roles/paas-docker/containers/auth-grove.sls

roles/paas-docker/containers/bugzilla.sls

roles/paas-docker/containers/cachet.sls

roles/paas-docker/containers/clickhouse.sls

roles/paas-docker/containers/docker-registry-api.sls

roles/paas-docker/containers/etherpad.sls

roles/paas-docker/containers/exim.sls

roles/paas-docker/containers/files/_tomcat/tomcat-users.xml

roles/paas-docker/containers/hauk.sls

roles/paas-docker/containers/hound.sls

roles/paas-docker/containers/init.sls

roles/paas-docker/containers/jenkins.sls

roles/paas-docker/containers/jenkins_agent.sls

roles/paas-docker/containers/kafka.sls

roles/paas-docker/containers/mastodon_sidekiq.sls

roles/paas-docker/containers/memcached.sls

roles/paas-docker/containers/mysql.sls

roles/paas-docker/containers/notifications.sls

roles/paas-docker/containers/openfire.sls

roles/paas-docker/containers/orbeon.sls

roles/paas-docker/containers/penpot_exporter.sls

roles/paas-docker/containers/penpot_web.sls

roles/paas-docker/containers/phabricator.sls

roles/paas-docker/containers/phpbb.sls

roles/paas-docker/containers/pixelfed.sls

roles/paas-docker/containers/postgresql.sls

roles/paas-docker/containers/rabbitmq.sls

roles/paas-docker/containers/redis.sls

roles/paas-docker/containers/registry.sls

roles/paas-docker/containers/relay.sls

roles/paas-docker/containers/sentry.sls

roles/paas-docker/containers/snuba.sls

roles/paas-docker/containers/symbolicator.sls

roles/paas-docker/containers/tommy.sls

roles/paas-docker/containers/zookeeper.sls

roles/paas-docker/docker/firewall.sls

roles/paas-docker/docker/images.sls

roles/paas-docker/docker/networks.sls

roles/paas-docker/docker/software.sls

roles/paas-docker/init.sls

roles/paas-docker/kernel/init.sls

roles/paas-docker/monitoring/init.sls

roles/paas-docker/nginx/config.sls

roles/paas-docker/nginx/files/vhosts/hauk.conf

roles/paas-docker/nginx/files/vhosts/openfire.conf

roles/paas-docker/nginx/files/vhosts/phabricator.conf

roles/paas-docker/nginx/files/vhosts/rabbitmq.conf

roles/paas-docker/nginx/files/vhosts/registry.conf

roles/paas-docker/nginx/files/vhosts/vault.conf

roles/paas-docker/nginx/firewall.sls

roles/paas-docker/nginx/selinux.sls

roles/paas-docker/systemd-unit/init.sls

roles/paas-docker/wrappers/init.sls

roles/paas-docker/wwwroot-502/init.sls

roles/paas-docker/wwwroot-content/base.sls

roles/paas-docker/wwwroot-content/selinux.sls

roles/paas-jails/jails/init.sls

roles/paas-lxc/lxc/init.sls

roles/prometheus/prometheus/service.sls

roles/redis/server/service.sls

roles/router/carp/files/carp.rc

roles/router/carp/init.sls

roles/saas-mediawiki/data/init.sls

roles/saas-mediawiki/mediawiki/config.sls

roles/saas-mediawiki/mediawiki/interwiki.sls

roles/saas-mediawiki/mediawiki/software.sls

roles/saas-mediawiki/nginx/config.sls

roles/saas-mediawiki/software/init.sls

roles/salt-primary/account/init.sls

roles/salt-primary/service/init.sls

roles/shellserver/odderon/service.sls

roles/shellserver/quassel-core/changepassword.sls

roles/shellserver/quassel-core/map.jinja

roles/shellserver/quassel-core/software.sls

roles/shellserver/userland-software/base.sls

roles/shellserver/userland-software/irc.sls

roles/shellserver/vault/config.sls

roles/shellserver/vhosts/init.sls

roles/shellserver/web-hosting/init.sls

roles/vault/policies/init.sls

roles/vault/vault/init.sls

roles/viperserv/account/init.sls

roles/viperserv/eggdrop/config.sls

roles/viperserv/eggdrop/cron.sls

roles/viperserv/eggdrop/service.sls

roles/viperserv/eggdrop/software.sls

roles/viperserv/fantoir/init.sls

roles/viperserv/rabbitmq-tcl/init.sls

roles/viperserv/wikidata-access-layer/code.sls

roles/webserver-alkane/account/init.sls

roles/webserver-alkane/alkane/init.sls

roles/webserver-alkane/directories/init.sls

roles/webserver-alkane/php/cleanup.sls

roles/webserver-alkane/php/files/php-fpm-pool.conf

roles/webserver-alkane/php/php-fpm.sls

roles/webserver-alkane/php/php.sls

roles/webserver-alkane/php/service.sls

roles/webserver-content/org/eglide/www.sls

roles/webserver-content/org/nasqueron/labs.sls

roles/webserver-content/org/wolfplex/api.sls

roles/webserver-content/space/hypership/www.sls

roles/webserver-core/nginx/config.sls

roles/webserver-legacy/jenkins-cd/content.sls

roles/webserver-legacy/php-sites/files.sls

roles/webserver-legacy/php-sites/files/php-fpm-pool.conf

roles/webserver-legacy/php-sites/php-fpm.sls

roles/webserver-legacy/php-sites/php.sls

roles/webserver-legacy/static-sites/init.sls

roles/webserver-legacy/tweaks/autochmod.sls