Differential D441

Improve code comments
ClosedPublic
Actions

Authored by dereckson on Jul 1 2016, 19:26.

Details

Reviewers

dereckson

Commits

rNOTIF8e1c4b5bfe6c: Improve code comments

Summary

End each sentence with a final dot for
Side edit: same amount of blank lines at class start and class end

Test Plan

Read again the comments. Regenerate doc.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

code-comments

Event Timeline

dereckson updated this revision to Diff 1070.Jul 1 2016, 19:26

dereckson retitled this revision from to Improve code comments.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/123/ (console: https://ci.nasqueron.org/job/test-notifications-phab/123/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/123/ for more details.

dereckson accepted this revision.Jul 1 2016, 19:44

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jul 1 2016, 19:44

Closed by commit rNOTIF8e1c4b5bfe6c: Improve code comments (authored by dereckson, committed by dereckson). · Explain WhyJul 1 2016, 19:45

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

app/

Analyzers/

GitHub/

GitHubPayloadAnalyzer.php

24 lines

97%

Phabricator/

PhabricatorPayloadAnalyzer.php

16 lines

70%

Diff 1070

View Options

app/Analyzers/GitHub/GitHubPayloadAnalyzer.php