Differential D4190

Accept then discard mails from Phabricator instances
ClosedPublic
Actions

Authored by dereckson on Sun, Aug 23, 19:25.

Tags

None

Referenced Files

	F45947120: D4190.diff
	Mon, Aug 24, 07:05

	F45872665: D4190.diff
	Sun, Aug 23, 21:55

	F45872097: D4190.id10992.diff
	Sun, Aug 23, 21:52

	F45872088: D4190.id10991.diff
	Sun, Aug 23, 21:52

Subscribers

None

Details

Reviewers

Maniphest Tasks

T2349: Create mail blackhole / silently discard mail to notifications-noreply@devcentral.nasqueron.org

Commits

rOPS8d066385e6b2: Accept then discard mails from Phabricator instances

Summary

Test Plan

check logs for Phabricator no-reply mails
ensure regular virtual mailboxes are still working

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Sun, Aug 23, 19:25

dereckson created this revision.

Harbormaster completed remote builds in B6838: Diff 10991.Sun, Aug 23, 19:25

Coherent variables names

Harbormaster completed remote builds in B6839: Diff 10992.Sun, Aug 23, 19:27

dereckson accepted this revision.Sun, Aug 23, 20:43

This revision is now accepted and ready to land.Sun, Aug 23, 20:43

dereckson mentioned this in T2349: Create mail blackhole / silently discard mail to notifications-noreply@devcentral.nasqueron.org.Sun, Aug 23, 20:45

Closed by commit rOPS8d066385e6b2: Accept then discard mails from Phabricator instances (authored by dereckson). · Explain WhySun, Aug 23, 20:48

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPS8d066385e6b2: Accept then discard mails from Phabricator instances.

dereckson added inline comments.Sun, Aug 23, 21:14

roles/mailserver/postfix/config.sls

Version deployed has a uncommitted fix on Complector for this typo.

diff --git a/roles/mailserver/postfix/config.sls b/roles/mailserver/postfix/config.sls
index df8796fa..95b3f0e0 100644
--- a/roles/mailserver/postfix/config.sls
+++ b/roles/mailserver/postfix/config.sls
@@ -26,7 +26,7 @@
     - source: salt://roles/mailserver/postfix/files/blackhole.cf
     - template: jinja
     - context:
-        discard_mailboxes: {{ pillar["postfix_config"].get("discard_mailboxes", [])
+        discard_mailboxes: {{ pillar["postfix_config"].get("discard_mailboxes", []) }}
 
 {{ dirs.etc }}/postfix/postfix-to-mailman.py:
   file.managed:

Revision Contents
Changeset List

Path

Size

pillar/

mailserver/

5 lines

roles/

mailserver/

postfix/

7 lines

files/

19 lines

6 lines

Diff 10993

pillar/mailserver/postfix.sls

Loading...

roles/mailserver/postfix/config.sls

Loading...

roles/mailserver/postfix/files/blackhole.cf

Loading...

roles/mailserver/postfix/files/main.cf

Loading...