Localisation for create_surname and create_given_name (part 2)
ClosedPublic
Actions

Authored by dereckson on Jul 9 2016, 19:20.

Details

Reviewers

dachary
• Ash-Crow

Maniphest Tasks

T892: .+prenom/.+nom: use localized labels

Commits

rDWD1310d574b829: Localisation for create_surname and create_given_name (part 2)

Summary

These scripts now actually use the localisation provided.

This is a follow-up for 66c0b27797dd. Fixes T892.

Side edit: import statements by alphabetical order.

Test Plan

https://www.wikidata.org/wiki/Q25712343 for create_surname
https://www.wikidata.org/wiki/Q25712302 for create_given_name

Diff Detail

Repository

rDWD Dæghrefn Wikidata access layer

Lint

Lint Passed

Unit

No Test Coverage

Branch

T892

Build Status

Buildable 661
Build 781: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1144.Jul 9 2016, 19:20

dereckson added a task: T892: .+prenom/.+nom: use localized labels.

dereckson retitled this revision from to .+prenom/.+nom: use localized labels.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added reviewers: • Ash-Crow, dachary.

dereckson retitled this revision from .+prenom/.+nom: use localized labels to Localisation for create_surname and create_given_name (part 2).Jul 9 2016, 19:22

dereckson updated this object.

It would be nice to have a comment explaining what is expected in the json files, although it's fairly easy to infer by reading the source. As it's getting more sophisticated, unit tests would also be welcome.

Other than this, the code looks good and the feature useful :-)

This revision is now accepted and ready to land.Jul 10 2016, 08:13

Closed by commit rDWD1310d574b829: Localisation for create_surname and create_given_name (part 2) (authored by dereckson, committed by dereckson). · Explain WhyJul 10 2016, 11:56

This revision was automatically updated to reflect the committed changes.