Paths

Table of Contentst

Differential D473

Style: single-quoted strings
ClosedPublic
Actions

Authored by dereckson on Jul 10 2016, 17:43.

Tags

None

Referenced Files

	F12259897: D473.id.diff
	Mon, Oct 13, 19:38

	F12258341: D473.id.diff
	Mon, Oct 13, 12:05

	Unknown Object (File)
	Sun, Oct 12, 10:36

	Unknown Object (File)
	Sun, Oct 12, 08:19

	Unknown Object (File)
	Sat, Oct 11, 03:26

	Unknown Object (File)
	Thu, Oct 9, 19:50

	Unknown Object (File)
	Thu, Oct 9, 19:50

	Unknown Object (File)
	Sat, Oct 4, 05:27

Subscribers

None

Details

Reviewers

Maniphest Tasks

T912: Follow the community Ruby Style Guide

Commits

rTOMMY40e0ee7b4af0: Style: single-quoted strings

Summary

Prefer single-quoted strings when we don't need
string interpolation or special symbols.

Test Plan

rubocop tommy.rb

Diff Detail

Repository

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	tommy.rb:32	Metrics/LineLength	RuboCop
Warning	tommy.rb:32	Style/HashSyntax	RuboCop
Warning	tommy.rb:33	Metrics/LineLength	RuboCop
Warning	tommy.rb:33	Style/HashSyntax	RuboCop
Warning	tommy.rb:35	Metrics/LineLength	RuboCop
Warning	tommy.rb:35	Style/HashSyntax	RuboCop
Warning	tommy.rb:36	Metrics/LineLength	RuboCop
Warning	tommy.rb:36	Style/HashSyntax	RuboCop
Warning	tommy.rb:36	Style/SpaceInsideParens	RuboCop

Unit

No Test Coverage

Branch

style-single-quoted (branched from master)

Build Status

Buildable 673
Build 793: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1159.Jul 10 2016, 17:43

dereckson retitled this revision from to Style: single-quoted strings.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jul 10 2016, 17:48

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jul 10 2016, 17:48

Single quotes issues fixed, let's continue style improve in further commits.

Closed by commit rTOMMY40e0ee7b4af0: Style: single-quoted strings (authored by dereckson, committed by dereckson). · Explain WhyJul 10 2016, 17:50

This revision was automatically updated to reflect the committed changes.

dereckson added a task: T912: Follow the community Ruby Style Guide.Jul 11 2016, 14:15

Revision Contents
Changeset List

Path

Size

22 lines

Diff 1159

tommy.rb

Loading...