Page MenuHomeDevCentral
Differential D484

RFC 7239 compliant preamble script for Phabricator
ClosedPublic
Actions

Authored by dereckson on Jul 10 2016, 23:44.
Tags
Referenced Files
F3929116: D484.id.diff
Sun, Dec 22, 07:42
Unknown Object (File)
Mon, Dec 16, 05:13
Unknown Object (File)
Thu, Dec 12, 05:40
Unknown Object (File)
Wed, Dec 11, 10:59
Unknown Object (File)
Tue, Dec 10, 23:36
Unknown Object (File)
Tue, Dec 10, 23:36
Unknown Object (File)
Tue, Dec 10, 23:20
Unknown Object (File)
Tue, Dec 10, 23:03
View All Files
Subscribers
Nasqueron Docker deployment squad

Details

Reviewers
Sandlayth
Maniphest Tasks
T915: Preamble script for Phabricator
Commits
rDPHAB892cd0a35934: RFC 7239 compliant preamble script for Phabricator
Summary

Fix headers to allow two things:

  • correct detection of http/https
  • remote address is use instead of Docker engine address

Reference:

Fixes T915.

Test Plan

Tested on https://devcentral.nasqueron.org/

Diff Detail

Repository
rDPHAB Docker image for Phabricator
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
preamble (branched from master)
Build Status
Buildable 685
Build 805: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1178.Jul 10 2016, 23:44
dereckson retitled this revision from to Preamble script for Phabricator.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: Sandlayth.
dereckson added a task: T915: Preamble script for Phabricator.
Herald added a project: Docker images. · View Herald TranscriptJul 10 2016, 23:44
Herald added a subscriber: Nasqueron Docker deployment squad. · View Herald Transcript
Sandlayth accepted this revision.Jul 11 2016, 06:59
Sandlayth edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2016, 06:59
dereckson retitled this revision from Preamble script for Phabricator to RFC 7239 compliant preamble script for Phabricator .Jul 11 2016, 11:03
dereckson updated this object.
dereckson edited edge metadata.
Closed by commit rDPHAB892cd0a35934: RFC 7239 compliant preamble script for Phabricator (authored by dereckson, committed by dereckson). · Explain WhyJul 11 2016, 11:07
This revision was automatically updated to reflect the committed changes.
dereckson mentioned this in T275: Nginx proxies request with 127.0.0.1 as IP address.Feb 14 2020, 17:42

Revision Contents
Changeset List

PathSize
files/
opt/
phabricator/
support/
15 lines

Diff 1178

View Options

files/opt/phabricator/support/preamble.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator