Page MenuHomeDevCentral
Differential D512

Refactor AccountHelper methods into a LocalizableMessage class
ClosedPublic
Actions

Authored by dereckson on Jul 11 2016, 20:05.
Tags
None
Referenced Files
F9675644: D512.diff
Wed, Jun 11, 17:41
Unknown Object (File)
Tue, Jun 10, 06:55
Unknown Object (File)
Tue, Jun 10, 04:08
Unknown Object (File)
Mon, Jun 9, 23:17
Unknown Object (File)
Tue, Jun 3, 12:52
Unknown Object (File)
Mon, Jun 2, 19:15
Unknown Object (File)
Mon, Jun 2, 06:20
Unknown Object (File)
Sun, Jun 1, 16:58
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rGROVEd656c017b130: Refactor AccountHelper methods into a LocalizableMessage class
Summary

AccountHelpers offered methods to prepare a localized message
to print to the console.

We extract them into LocalizableMessage, a fluent class to localize
and transform a message for display.

For convenience, an UserAttribute class is provided for AccountInfo.

Test Plan
  • Run new tests
  • ./artisan account:info 1

Diff Detail

Repository
rGROVE Auth Grove
Lint
Lint Passed
Unit
Tests Passed
Branch
LocalizableMessage
Build Status
Buildable 717
Build 843: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1237.Jul 11 2016, 20:05
dereckson retitled this revision from to Refactor AccountHelper methods into a LocalizableMessage class.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson accepted this revision.Jul 11 2016, 20:06
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2016, 20:06
dereckson added a comment.Jul 11 2016, 20:07
$ ant phpmd
Buildfile: /home/ubuntu/workspace/auth-grove/build.xml

phpmd:
    [phpmd] 

BUILD SUCCESSFUL
Total time: 2 seconds

With this commit, phpmd is happy for our Nasqueron ruleset.

Closed by commit rGROVEd656c017b130: Refactor AccountHelper methods into a LocalizableMessage class (authored by dereckson, committed by dereckson). · Explain WhyJul 11 2016, 20:07
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Console/
Commands/
13 lines
Services/
13 lines
Internationalization/
103 lines
12 lines
tests/
Internationalization/
49 lines
12 lines

Diff 1237

View Options

app/Console/Commands/AccountInfo.php

Loading...
View Options

app/Console/Services/AccountHelpers.php

Loading...
View Options

app/Internationalization/LocalizableMessage.php

Loading...
View Options

app/Internationalization/UserAttribute.php

Loading...
View Options

tests/Internationalization/LocalizableMessageTest.php

Loading...
View Options

tests/Internationalization/UserAttributeTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator