Don't use adjoining classes in CSS
ClosedPublic
Actions

Authored by dereckson on Nov 14 2015, 19:36.

Details

Reviewers

Commits

rDOCKERWWW385494aa840f: Don't use adjoining classes in CSS

Summary

We borrowed a snippet from Batch documentation, offering to use
.batch.large. It seems better to create an utility .icon-large class
so we can reuse this rule for other icons.

See P127.

Test Plan

check there is no difference in rendering

Diff Detail

Repository

rDOCKERWWW Docker images website

Lint

Lint Passed

Unit

No Test Coverage

Branch

arc

Build Status

Buildable 62
Build 62: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 133.Nov 14 2015, 19:36

dereckson retitled this revision from to Don't use adjoining classes in CSS.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson mentioned this in D64: Arc configuration.Nov 14 2015, 19:45

dereckson accepted this revision.Nov 14 2015, 19:45

dereckson edited edge metadata.

This revision is now accepted and ready to land.Nov 14 2015, 19:45

dereckson mentioned this in rDOCKERWWW154e1c7158bb: Arc configuration.Nov 14 2015, 20:55

Closed by commit rDOCKERWWW385494aa840f: Don't use adjoining classes in CSS (authored by dereckson, committed by dereckson). · Explain WhyNov 14 2015, 21:54

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

css/

app.css

2 lines

index.html

8 lines

Diff 133

View Options

css/app.css