Differential D553

Simplify layout structure around .darken
ClosedPublic
Actions

Authored by dereckson on Jul 24 2016, 19:14.

Details

Reviewers

dereckson

Commits

rVIPERWWW083c4d063b90: Simplify layout structure around .darken

Summary

Footer and .darken has no padding margin defined, so the footer
doesn't need to be in darken (it has a plain color).

This configuration has been detecting trying Motion UI:
when the footer was fading out, darken class transparency
still appeared.

Test Plan

Check on Chrome and Firefox on several resolutions

Diff Detail

Repository

rVIPERWWW Dæghrefn website

Lint

Lint Passed

Unit

No Test Coverage

Branch

footer-after-darken

Build Status

Buildable 805
Build 939: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1348.Jul 24 2016, 19:14

dereckson retitled this revision from to Simplify layout structure around .darken.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jul 24 2016, 19:19

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jul 24 2016, 19:19

Closed by commit rVIPERWWW083c4d063b90: Simplify layout structure around .darken (authored by dereckson, committed by dereckson). · Explain WhyJul 24 2016, 19:19

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

pages/

index.html

176 lines

Diff 1348

View Options

Simplify layout structure around .darkenClosedPublicActions