Define explicitely constructors visibility
ClosedPublic
Actions

Authored by dereckson on Aug 2 2016, 20:01.

Tags

None

Referenced Files

	F3313286: D594.diff
	Fri, Jul 5, 18:21

	Unknown Object (File)
	Thu, Jul 4, 10:49

	Unknown Object (File)
	Thu, Jul 4, 06:18

	Unknown Object (File)
	Wed, Jul 3, 14:11

	Unknown Object (File)
	Sat, Jun 29, 07:30

	Unknown Object (File)
	Sat, Jun 29, 03:52

	Unknown Object (File)
	Wed, Jun 26, 20:19

	Unknown Object (File)
	Wed, Jun 26, 14:06

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rNOTIFacd2eface48f: Define explicitely constructors visibility

Summary

To improve code readability, constructor visibility should be
explicitely defined.

Test Plan

no op

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

method-visibility-should-be-explicit

Event Timeline

dereckson updated this revision to Diff 1442.Aug 2 2016, 20:01

dereckson retitled this revision from to Define explicitely constructors visibility.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Aug 2 2016, 20:03

dereckson edited edge metadata.

This revision is now accepted and ready to land.Aug 2 2016, 20:03

Closed by commit rNOTIFacd2eface48f: Define explicitely constructors visibility (authored by dereckson, committed by dereckson). · Explain WhyAug 2 2016, 20:04

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

app/

Actions/

AMQPAction.php

2 lines

100%

NotifyNewCommitsAction.php

2 lines

100%

Diff 1442

View Options

app/Actions/AMQPAction.php