Page MenuHomeDevCentral
Differential D334

API dependency injection for ProjectsMap
ClosedPublic
Actions

Authored by dereckson on Mar 9 2016, 06:02.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 02:23
Unknown Object (File)
Sat, Nov 9, 19:00
Unknown Object (File)
Sat, Nov 9, 16:47
Unknown Object (File)
Sat, Nov 9, 15:32
Unknown Object (File)
Sat, Nov 9, 15:14
Unknown Object (File)
Sun, Oct 27, 14:51
Unknown Object (File)
Thu, Oct 24, 02:27
Unknown Object (File)
Sun, Oct 20, 12:19
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Commits
rNOTIF123f184ddad5: API dependency injection for ProjectsMap
Summary

This commit also reverts 8758ba5 and improves fea5b9c.

Test Plan

New tests for ProjectsMap

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
test/ProjectsMap

Event Timeline

dereckson updated this revision to Diff 794.Mar 9 2016, 06:02
dereckson retitled this revision from to API dependency injection for ProjectsMap.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
alken-orin added a subscriber: alken-orin.Mar 9 2016, 06:09

Build started: https://ci.nasqueron.org/job/test-notifications-phab/119/ (console: https://ci.nasqueron.org/job/test-notifications-phab/119/console)

alken-orin added a comment.Mar 9 2016, 06:09

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/119/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/119/console

alken-orin added a comment.Mar 9 2016, 13:05

Build started: https://ci.nasqueron.org/job/test-notifications-phab/120/ (console: https://ci.nasqueron.org/job/test-notifications-phab/120/console)

alken-orin added a comment.Mar 9 2016, 13:06

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/120/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/120/console

dereckson updated this revision to Diff 1476.Aug 10 2016, 19:24
dereckson edited edge metadata.

Rebased against D333.

dereckson accepted this revision.Aug 10 2016, 19:50
dereckson edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2016, 19:50
Closed by commit rNOTIF123f184ddad5: API dependency injection for ProjectsMap (authored by dereckson, committed by dereckson). · Explain WhyAug 10 2016, 19:51
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
app/
Contracts/
24 lines--
15 lines--
Phabricator/
34 lines--
4 lines100%
Loading...
33 lines95%
Loading...
tests/
Phabricator/
28 lines--

Diff 1476

View Options

app/Contracts/APIClient.php

Loading...
View Options

app/Contracts/APIFactory.php

Loading...
View Options

app/Phabricator/PhabricatorAPI.php

Loading...
View Options

app/Phabricator/PhabricatorAPIFactory.php

Loading...
View Options

app/Phabricator/ProjectsMap.php

Loading...
View Options

tests/Phabricator/ProjectsMapTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator