Differential D606

PhabricatorAPI static constructors throw exceptions
ClosedPublic
Actions

Authored by dereckson on Aug 11 2016, 02:27.

Details

Reviewers

dereckson

Commits

rNOTIF291a59a6a53a: PhabricatorAPI static constructors throw exceptions

Summary

PhabricatorAPI class offered a incoherent behavior for forInstance
and forProject methods.

This change standardizes the behavior to throw an exception on
failure in forInstance of forProject methods.

Test Plan

New unit tests

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

tests/PhabricatorAPI-exceptions

Event Timeline

dereckson updated this revision to Diff 1480.Aug 11 2016, 02:27

dereckson retitled this revision from to PhabricatorAPI static constructors throw exceptions.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Aug 11 2016, 11:24

dereckson edited edge metadata.

This revision is now accepted and ready to land.Aug 11 2016, 11:24

Closed by commit rNOTIF291a59a6a53a: PhabricatorAPI static constructors throw exceptions (authored by dereckson, committed by dereckson). · Explain WhyAug 11 2016, 11:27

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

app/

Phabricator/

PhabricatorAPI.php

6 lines

21%

tests/

Phabricator/

PhabricatorAPITest.php

36 lines

Diff 1480

View Options

app/Phabricator/PhabricatorAPI.php