Page MenuHomeDevCentral

PhabricatorAPI static constructors throw exceptions
ClosedPublic

Authored by dereckson on Aug 11 2016, 02:27.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 11:19
Unknown Object (File)
Fri, Dec 20, 11:13
Unknown Object (File)
Fri, Dec 20, 05:54
Unknown Object (File)
Tue, Dec 17, 00:49
Unknown Object (File)
Fri, Dec 13, 16:13
Unknown Object (File)
Thu, Dec 12, 01:32
Unknown Object (File)
Tue, Dec 10, 15:27
Unknown Object (File)
Tue, Dec 10, 14:45
Subscribers
None

Details

Summary

PhabricatorAPI class offered a incoherent behavior for forInstance
and forProject methods.

This change standardizes the behavior to throw an exception on
failure in forInstance of forProject methods.

Test Plan

New unit tests

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
tests/PhabricatorAPI-exceptions

Event Timeline

dereckson retitled this revision from to PhabricatorAPI static constructors throw exceptions.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2016, 11:24
This revision was automatically updated to reflect the committed changes.