Page MenuHomeDevCentral
Differential D616

Define explicitly method visibility
ClosedPublic
Actions

Authored by dereckson on Aug 18 2016, 17:23.
Tags
None
Referenced Files
F3748871: D616.id1510.diff
Sat, Nov 16, 11:07
F3748791: D616.id1511.diff
Sat, Nov 16, 10:43
F3748352: D616.diff
Sat, Nov 16, 08:24
Unknown Object (File)
Mon, Nov 11, 04:09
Unknown Object (File)
Sun, Nov 10, 00:19
Unknown Object (File)
Wed, Nov 6, 23:55
Unknown Object (File)
Wed, Nov 6, 23:21
Unknown Object (File)
Fri, Nov 1, 05:05
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Commits
rGROVEb3ae033adfc2: Define explicitly method visibility
Summary

In PHP, methods are by default public when no visibility
operator is defined. To mark them explicitely as public
improves code legibility. Especially as this is not the
case in every language

Diff Detail

Repository
rGROVE Auth Grove
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1510.Aug 18 2016, 17:23
dereckson retitled this revision from to Define explicitly method visibility.
dereckson updated this object.
dereckson added a reviewer: dereckson.
alken-orin added a subscriber: alken-orin.Aug 18 2016, 17:28

Build is green https://ci.nasqueron.org/job/test-auth-grove-phab/4/ for more details.

dereckson accepted this revision.Aug 18 2016, 18:00
dereckson edited edge metadata.
This revision is now accepted and ready to land.Aug 18 2016, 18:00
Closed by commit rGROVEb3ae033adfc2: Define explicitly method visibility (authored by dereckson, committed by dereckson). · Explain WhyAug 18 2016, 18:01
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Internationalization/
2 lines
Services/
2 lines
tests/
Console/
Commands/
2 lines
Controller/
Auth/
2 lines
Helpers/
2 lines
Models/
2 lines

Diff 1511

View Options

app/Internationalization/UserAttribute.php

Loading...
View Options

app/Services/FindableByAttribute.php

Loading...
View Options

tests/Console/Commands/DatabaseShellTest.php

Loading...
View Options

tests/Controller/Auth/AuthControllerTest.php

Loading...
View Options

tests/Helpers/RoutingTest.php

Loading...
View Options

tests/Models/UserTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator