Differential D636

Trigger build to Docker Hub
ClosedPublic
Actions

Authored by dereckson on Aug 24 2016, 22:31.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 15, 13:46

	Unknown Object (File)
	Wed, Nov 13, 04:47

	Unknown Object (File)
	Tue, Nov 12, 15:23

	Unknown Object (File)
	Sun, Nov 10, 00:09

	Unknown Object (File)
	Sun, Nov 10, 00:09

	Unknown Object (File)
	Wed, Nov 6, 23:56

	Unknown Object (File)
	Wed, Nov 6, 23:21

	Unknown Object (File)
	Tue, Nov 5, 21:17

Subscribers

Details

Reviewers

Maniphest Tasks

T959: Trigger Docker Hub build when source repository is updated

Commits

rNOTIFe4b94f5c52b9: Trigger build to Docker Hub

Summary

When a code repository is updated, we need to also update the Docker
image.

Fixes T959.

Test Plan

fire a GitHub push event
check it triggers a new build on Docker Hub

API reply

…
{
  "image": "nasqueron/notifications",
  "action": "TriggerDockerHubBuildAction",
  "error": null
},
…

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

No Test Coverage

Branch

DockerHub

Unit TestsFailed
View All

	Time	Test
	4,872 ms	Jenkins > Nasqueron\Notifications\Tests\Providers\EventServiceProviderTest::Unknown Unit Message ("")
	142 ms	Jenkins > Nasqueron\Notifications\Tests\Actions\AMQPActionTest::Unknown Unit Message ("")
	31 ms	Jenkins > Nasqueron\Notifications\Tests\Actions\ActionErrorTest::Unknown Unit Message ("")
	478 ms	Jenkins > Nasqueron\Notifications\Tests\Actions\ActionsReportTest::Unknown Unit Message ("")
	31 ms	Jenkins > Nasqueron\Notifications\Tests\Actions\NotifyNewCommitsActionTest::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 156 Passed)

Event Timeline

dereckson updated this revision to Diff 1589.Aug 24 2016, 22:31

dereckson retitled this revision from to WIP: trigger build to Docker Hub.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson added a task: T959: Trigger Docker Hub build when source repository is updated.

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/186/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/186/console

dereckson planned changes to this revision.Aug 28 2016, 13:42

dereckson added inline comments.

app/Jobs/NotifyNewCommitsToDockerHub.php
79	We'll do this part instead in a Keruald DockerHub library.

Use Keruald/OockerHub library, listener

Build is green https://ci.nasqueron.org/job/test-notifications-phab/187/ for more details.

Library will handle build trigger

Build is green https://ci.nasqueron.org/job/test-notifications-phab/188/ for more details.

Rebased

Build is green https://ci.nasqueron.org/job/test-notifications-phab/207/ for more details.

dereckson added a parent revision: D650: Add factory to generate TriggerBuild classes.Sep 3 2016, 00:40

Rebased against D650.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/210/ for more details.

Let's add in the factory a capability to check if we've a token for a repo, then use that here.

Mapping seems to be currently a YAGNI: it's reasonnable to wait someone wants to use this for repos with different names on DockerHub and GitHub.

app/Listeners/DockerHubListener.php
40	Mapping by name could be more interesting: we only have to check if we've a token with this name.

Release candidate commit

Build is green https://ci.nasqueron.org/job/test-notifications-phab/212/ for more details.

dereckson added a parent revision: D653: TriggerBuildFactory::hasToken.Sep 4 2016, 01:07

dereckson retitled this revision from WIP: trigger build to Docker Hub to Trigger build to Docker Hub.

Last details, ready to merge.

Unit tests needed.

dereckson accepted this revision.Sep 4 2016, 01:29

dereckson edited edge metadata.

dereckson marked an inline comment as done.

This revision is now accepted and ready to land.Sep 4 2016, 01:29

Build is green https://ci.nasqueron.org/job/test-notifications-phab/213/ for more details.

Closed by commit rNOTIFe4b94f5c52b9: Trigger build to Docker Hub (authored by dereckson, committed by dereckson). · Explain WhySep 4 2016, 15:57

This revision was automatically updated to reflect the committed changes.

dereckson mentioned this in D655: Test TriggerDockerHubBuildAction.Sep 4 2016, 17:09

dereckson mentioned this in rNOTIFe03624de78b8: Test TriggerDockerHubBuildAction.Sep 4 2016, 18:11

Revision Contents
Changeset List

Path

Size

app/

Jobs/

NotifyNewCommitsToDockerHub.php

94 lines

Listeners/

DockerHubListener.php

15 lines

Diff 1589

app/Jobs/NotifyNewCommitsToDockerHub.php

Loading...

app/Listeners/DockerHubListener.php

Loading...