Paths

Table of Contentst

Differential D637

DockerImage::loadFromSlashNotation
ClosedPublic
Actions

Authored by dereckson on Aug 28 2016, 14:05.

Details

Reviewers

dereckson

Maniphest Tasks

T965: Create a Docker Hub client API library to trigger builds

Commits

rKDOCKERHUB59a96ef2cbae: DockerImage::loadFromSlashNotation

Summary

API users aren't expected to split themselves their acme/foo image
notation in "acme" and "foo", it's more convenient to provide a static
constructor to do it directly in DockerImage abstract class.

Test Plan

New unit tests in DockerHubImage, which implements DockerImage.

Diff Detail

Repository

rKDOCKERHUB Keruald Docker Hub

Lint

Lint Passed

Unit

Tests Passed

Branch

master

Build Status

Buildable 961
Build 1148: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1591.Aug 28 2016, 14:05

dereckson retitled this revision from to DockerImage::loadFromSlashNotation.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Aug 28 2016, 14:06

dereckson edited edge metadata.

dereckson added inline comments.

src/DockerImage.php
49	document `@throws`

This revision is now accepted and ready to land.Aug 28 2016, 14:06

+@throws

Closed by commit rKDOCKERHUB59a96ef2cbae: DockerImage::loadFromSlashNotation (authored by dereckson, committed by dereckson). · Explain WhyAug 28 2016, 14:07

This revision was automatically updated to reflect the committed changes.

dereckson added a task: T965: Create a Docker Hub client API library to trigger builds.Aug 28 2016, 14:35

Revision Contents
Changeset List

Path

Size

src/

DockerImage.php

20 lines

tests/

DockerHubImageTest.php

12 lines

Diff 1591

View Options

src/DockerImage.php