Page MenuHomeDevCentral

Disable legacy behavior always_populate_raw_post_data
ClosedPublic

Authored by dereckson on Sep 2 2016, 21:48.
Referenced Files
F6964606: D646.id1654.diff
Fri, Apr 18, 07:00
F6957375: D646.id.diff
Fri, Apr 18, 03:27
Unknown Object (File)
Thu, Apr 17, 14:52
Unknown Object (File)
Wed, Apr 16, 13:41
Unknown Object (File)
Wed, Apr 16, 09:56
Unknown Object (File)
Tue, Apr 15, 07:16
Unknown Object (File)
Fri, Apr 11, 10:23
Unknown Object (File)
Fri, Apr 11, 04:19

Details

Summary

According Phabricator, this configuration triggers a warning:

always_populate_raw_post_data = 1
display_errors = 1
display_startup_errors = 1
error_reporting = -1

Warning text:

Automatically populating $HTTP_RAW_POST_DATA is deprecated and
will be removed in a future version. To avoid this warning set
'always_populate_raw_post_data' to '-1' in php.ini and use the
php://input stream instead.

Phabricator has raised a setup issue about this since 2016-08-26.

Some Docker images build on the top of this one use raw post
data, like rDNOTIF. But they already use php://input.

So it's safe to disable this.

References:

Fixes T1004.

Test Plan

Tested successfully on DevCentral.

Diff Detail

Repository
rDPHPFPM Docker image for Nginx, php-fpm
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
T1004 (branched from master)
Build Status
Buildable 988
Build 1193: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Disable legacy behavior always_populate_raw_post_data.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: Sandlayth.
dereckson updated this object.
This revision is now accepted and ready to land.Sep 4 2016, 18:37
This revision was automatically updated to reflect the committed changes.