Differential D650

Add factory to generate TriggerBuild classes
ClosedPublic
Actions

Authored by dereckson on Sep 3 2016, 00:40.

Details

Reviewers

dereckson

Maniphest Tasks

T959: Trigger Docker Hub build when source repository is updated

Commits

rKDOCKERHUBdde22992fea7: Add factory to generate TriggerBuild classes

Summary

A factory class allow to prepare a service provider
to get TriggerBuild instances, configuring only once
a HTTP client and the tokens to use.

Ref T959.

Test Plan

new tests
test implementation for Notifications center, as a Laravel service provider.

Diff Detail

Repository

rKDOCKERHUB Keruald Docker Hub

Lint

Lint Passed

Unit

Tests Passed

Branch

factory

Build Status

Buildable 993
Build 1198: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1637.Sep 3 2016, 00:40

dereckson retitled this revision from to Add factory to generate TriggerBuild classes.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson updated this object.Sep 3 2016, 00:40

dereckson added a task: T959: Trigger Docker Hub build when source repository is updated.

dereckson added a child revision: D636: Trigger build to Docker Hub.

dereckson accepted this revision.Sep 3 2016, 02:06

dereckson edited edge metadata.

This revision is now accepted and ready to land.Sep 3 2016, 02:06

Closed by commit rKDOCKERHUBdde22992fea7: Add factory to generate TriggerBuild classes (authored by dereckson, committed by dereckson). · Explain WhySep 3 2016, 02:08

This revision was automatically updated to reflect the committed changes.

dereckson mentioned this in D636: Trigger build to Docker Hub.Sep 3 2016, 23:34

Revision Contents
Changeset List

Path

Size

src/

Build/

TriggerBuildFactory.php

85 lines

tests/

Build/

TriggerBuildFactoryTest.php

56 lines

Diff 1637

View Options

src/Build/TriggerBuildFactory.php