Differential D651

Add DockerHub support
ClosedPublic
Actions

Authored by dereckson on Sep 3 2016, 01:57.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 18, 20:36

	Unknown Object (File)
	Thu, Nov 14, 17:40

	Unknown Object (File)
	Tue, Nov 12, 20:25

	Unknown Object (File)
	Mon, Nov 11, 02:08

	Unknown Object (File)
	Sat, Nov 9, 17:25

	Unknown Object (File)
	Sat, Nov 9, 16:48

	Unknown Object (File)
	Sat, Nov 9, 13:48

	Unknown Object (File)
	Wed, Nov 6, 23:37

Subscribers

Details

Reviewers

Maniphest Tasks

T959: Trigger Docker Hub build when source repository is updated

Commits

rNOTIF6e22e379fcdf: Add DockerHub support

Summary

This change adds a service provider and a DockerHub facade to
be able to trigger a build for an image hosted on Docker Hub.

This will allow the notifications center to trigger new builds
when some event occurs, for example when app code is updated.

Ref T959.

Test Plan

Unit tests.

Tested in real conditions with:

$ php artisan tinker
Psy Shell v0.7.2 (PHP 5.6.16-1+deb.sury.org~trusty+1 — cli) by Justin Hileman
>>> $factory = App::make('dockerhub');
=> Keruald\DockerHub\Build\TriggerBuildFactory {#668}
>>> $factory->build('nasqueron/aphlict');
=> null
>>> $factory->build('nasqueron/aphlictx');
InvalidArgumentException with message 'No token found for image nasqueron/aphlictx.'
>>> DockerHub::build('nasqueron/auth-grove');
=> null

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

service-provider-dockerhub (branched from master)

Event Timeline

dereckson updated this revision to Diff 1638.Sep 3 2016, 01:57

dereckson retitled this revision from to Add DockerHub support.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a task: T959: Trigger Docker Hub build when source repository is updated.

dereckson accepted this revision.Sep 3 2016, 02:01

dereckson added a reviewer: dereckson.

dereckson added inline comments.

storage/app/.gitignore
3	\n
tests/data/DockerHubTokens.json
4	\n

This revision is now accepted and ready to land.Sep 3 2016, 02:01

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/208/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/208/console

dereckson edited the test plan for this revision. (Show Details)Sep 3 2016, 22:51

dereckson edited edge metadata.

Ready to merge.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/209/ for more details.

Closed by commit rNOTIF6e22e379fcdf: Add DockerHub support (authored by dereckson, committed by dereckson). · Explain WhySep 3 2016, 23:09

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Facades/

21 lines

Providers/

DockerHubServiceProvider.php

50 lines

1 line

config/

2 lines

4 lines

storage/

app/

1 line

tests/

Facades/

DockerHubTest.php

21 lines

Providers/

DockerHubServiceProviderTest.php

36 lines

data/

DockerHubTokens.json

3 lines

Diff 1638

app/Facades/DockerHub.php

Loading...

app/Providers/DockerHubServiceProvider.php

Loading...

composer.json

Loading...

config/app.php

Loading...

config/services.php

Loading...

storage/app/.gitignore

Loading...

tests/Facades/DockerHubTest.php

Loading...

tests/Providers/DockerHubServiceProviderTest.php

Loading...

tests/data/DockerHubTokens.json

Loading...