Page MenuHomeDevCentral
Differential D636

Trigger build to Docker Hub
ClosedPublic
Actions

Authored by dereckson on Aug 24 2016, 22:31.
Tags
None
Referenced Files
F3716891: D636.id1589.diff
Tue, Nov 5, 21:17
F3716864: D636.id1597.diff
Tue, Nov 5, 21:09
Unknown Object (File)
Fri, Nov 1, 07:44
Unknown Object (File)
Sun, Oct 27, 05:08
Unknown Object (File)
Fri, Oct 25, 20:08
Unknown Object (File)
Wed, Oct 23, 04:21
Unknown Object (File)
Tue, Oct 22, 05:17
Unknown Object (File)
Mon, Oct 21, 17:07
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Maniphest Tasks
T959: Trigger Docker Hub build when source repository is updated
Commits
rNOTIFe4b94f5c52b9: Trigger build to Docker Hub
Summary

When a code repository is updated, we need to also update the Docker
image.

Fixes T959.

Test Plan
  • fire a GitHub push event
  • check it triggers a new build on Docker Hub
API reply
…
{
  "image": "nasqueron/notifications",
  "action": "TriggerDockerHubBuildAction",
  "error": null
},
…

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1589.Aug 24 2016, 22:31
dereckson retitled this revision from to WIP: trigger build to Docker Hub.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson added a task: T959: Trigger Docker Hub build when source repository is updated.
alken-orin added a subscriber: alken-orin.Aug 24 2016, 22:48

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/186/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/186/console

dereckson planned changes to this revision.Aug 28 2016, 13:42
dereckson added inline comments.
app/Jobs/NotifyNewCommitsToDockerHub.php
79 ↗(On Diff #1589)

We'll do this part instead in a Keruald DockerHub library.

dereckson updated this revision to Diff 1594.Aug 28 2016, 19:28
dereckson edited edge metadata.

Use Keruald/OockerHub library, listener

alken-orin added a comment.Aug 28 2016, 19:44

Build is green https://ci.nasqueron.org/job/test-notifications-phab/187/ for more details.

dereckson updated this revision to Diff 1597.Aug 31 2016, 19:30
dereckson edited edge metadata.

Library will handle build trigger

alken-orin added a comment.Aug 31 2016, 19:46

Build is green https://ci.nasqueron.org/job/test-notifications-phab/188/ for more details.

dereckson updated this revision to Diff 1627.Sep 2 2016, 21:30

Rebased

alken-orin added a comment.Sep 2 2016, 21:36

Build is green https://ci.nasqueron.org/job/test-notifications-phab/207/ for more details.

dereckson added a parent revision: D650: Add factory to generate TriggerBuild classes.Sep 3 2016, 00:40
dereckson updated this revision to Diff 1642.Sep 3 2016, 23:34

Rebased against D650.

alken-orin added a comment.Sep 3 2016, 23:38

Build is green https://ci.nasqueron.org/job/test-notifications-phab/210/ for more details.

dereckson planned changes to this revision.Sep 3 2016, 23:39
dereckson marked an inline comment as done.

Let's add in the factory a capability to check if we've a token for a repo, then use that here.

Mapping seems to be currently a YAGNI: it's reasonnable to wait someone wants to use this for repos with different names on DockerHub and GitHub.

app/Listeners/DockerHubListener.php
40

Mapping by name could be more interesting: we only have to check if we've a token with this name.

dereckson updated this revision to Diff 1649.Sep 4 2016, 01:03

Release candidate commit

alken-orin added a comment.Sep 4 2016, 01:05

Build is green https://ci.nasqueron.org/job/test-notifications-phab/212/ for more details.

dereckson added a parent revision: D653: TriggerBuildFactory::hasToken.Sep 4 2016, 01:07
dereckson retitled this revision from WIP: trigger build to Docker Hub to Trigger build to Docker Hub.
dereckson updated this revision to Diff 1650.Sep 4 2016, 01:26
dereckson edited the test plan for this revision. (Show Details)

Last details, ready to merge.

Unit tests needed.

dereckson accepted this revision.Sep 4 2016, 01:29
dereckson edited edge metadata.
dereckson marked an inline comment as done.
This revision is now accepted and ready to land.Sep 4 2016, 01:29
alken-orin added a comment.Sep 4 2016, 01:30

Build is green https://ci.nasqueron.org/job/test-notifications-phab/213/ for more details.

Closed by commit rNOTIFe4b94f5c52b9: Trigger build to Docker Hub (authored by dereckson, committed by dereckson). · Explain WhySep 4 2016, 15:57
This revision was automatically updated to reflect the committed changes.
dereckson mentioned this in D655: Test TriggerDockerHubBuildAction.Sep 4 2016, 17:09
dereckson mentioned this in rNOTIFe03624de78b8: Test TriggerDockerHubBuildAction.Sep 4 2016, 18:11

Revision Contents
Changeset List

PathSize
app/
Actions/
21 lines
Jobs/
87 lines
Listeners/
81 lines
2 lines
config/
1 line

Diff 1651

View Options

app/Actions/TriggerDockerHubBuildAction.php

Loading...
View Options

app/Jobs/TriggerDockerHubBuild.php

Loading...
View Options

app/Listeners/DockerHubListener.php

Loading...
View Options

composer.json

Loading...
View Options

config/app.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator