Differential D715

Fix 404 issues on nginx
ClosedPublic
Actions

Authored by dereckson on Nov 16 2016, 02:43.

Details

Reviewers

dereckson

Commits

rTOOLSec12f90b884a: Fix 404 issues on nginx

Summary

There is a kludge to get around a "known bug" in Document::find_document.

This kludge makes on a server not touched by this bug an attempt to reinclude /index.php instead to serve a 404 page.

To try to target every server configuration isn't the 2016 way.

This reverts a fix introduced in c35861b0.

Test Plan

Visit a 404 page on a nginx server

Diff Detail

Repository

rTOOLS Nasqueron Tools

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

fix-404 (branched from master)

Build Status

Buildable 1087
Build 1302: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1797.Nov 16 2016, 02:43

dereckson retitled this revision from to Drop not used bugged URL fix.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson retitled this revision from Drop not used bugged URL fix to Fix 404 issues on nginx.Nov 16 2016, 02:49

dereckson updated this object.

dereckson accepted this revision.Nov 16 2016, 02:55

dereckson edited edge metadata.

This revision is now accepted and ready to land.Nov 16 2016, 02:55

Closed by commit rTOOLSec12f90b884a: Fix 404 issues on nginx (authored by dereckson, committed by dereckson). · Explain WhyNov 16 2016, 02:55

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

includes/

document.php

12 lines

Diff 1797

View Options

Fix 404 issues on nginxClosedPublicActions