Differential D717

Fix meta tags parser
ClosedPublic
Actions

Authored by dereckson on Nov 16 2016, 03:37.

Details

Reviewers

dereckson

Maniphest Tasks

T1050: Handle <meta name="..." lang="..." content="..." />

Commits

rSTG5500f9769ea0: Fix meta tags parser

Summary

This approach isn't satisfactory: it uses regexp instead to parse tokens.
But it's carefully tested and good result.

Regexp by Bobble Bubble.

Test Plan

Check tags from http://www.footofeminin.fr/LFP-Nathalie-BOY-DE-LA-TOUR-une-femme-elue-a-la-tete-du-foot-pro-francais_a13077.html

Diff Detail

Repository

rSTG Source templates generator

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

metatags

Build Status

Buildable 1089
Build 1304: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1801.Nov 16 2016, 03:37

dereckson retitled this revision from to Fix meta tags parser.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson planned changes to this revision.Nov 16 2016, 03:39

dereckson added inline comments.

page.php
206	itemprop missing

+itemprop

$out → $match

dereckson accepted this revision.Nov 16 2016, 03:42

dereckson edited edge metadata.

This revision is now accepted and ready to land.Nov 16 2016, 03:42

Closed by commit rSTG5500f9769ea0: Fix meta tags parser (authored by dereckson, committed by dereckson). · Explain WhyNov 16 2016, 03:43

This revision was automatically updated to reflect the committed changes.

dereckson added a task: T1050: Handle <meta name="..." lang="..." content="..." />.Nov 16 2016, 04:23

Revision Contents
Changeset List

Path

Size

page.php

67 lines

Diff 1801

View Options

Fix meta tags parserClosedPublicActions