Paths

Table of Contentst

Prune extraneous unused parameter
ClosedPublic
Actions

Authored by dereckson on Dec 29 2016, 19:43.

Tags

None

Referenced Files

	F3164151: D773.diff
	Wed, Jun 26, 13:01

	Unknown Object (File)
	Tue, Jun 25, 09:27

	Unknown Object (File)
	Mon, Jun 24, 18:54

	Unknown Object (File)
	Mon, Jun 24, 05:47

	Unknown Object (File)
	Mon, Jun 24, 01:47

	Unknown Object (File)
	Sun, Jun 23, 20:59

	Unknown Object (File)
	Fri, Jun 21, 06:09

	Unknown Object (File)
	Fri, Jun 21, 01:59

View All Files

Subscribers

alken-orin

Details

Reviewers

dereckson

Commits

rNOTIF8c415781711f: Prune extraneous unused parameter

Summary

BasePayloadAnalyzer::loadConfiguration uses $this->project
and so doesn't need anymore the project as parameter.

Test Plan

Run tests
Run phan, check there isn't any PhanParamTooMany

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

master

Event Timeline

+PhabricatorPayloadAnalyzer

Build is green https://ci.nasqueron.org/job/test-notifications-phab/234/ for more details.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/235/ for more details.

dereckson accepted this revision.Dec 29 2016, 19:58

dereckson edited edge metadata.

This revision is now accepted and ready to land.Dec 29 2016, 19:58

Closed by commit rNOTIF8c415781711f: Prune extraneous unused parameter (authored by dereckson, committed by dereckson). · Explain WhyDec 29 2016, 19:59

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Analyzers/

BasePayloadAnalyzer.php

2 lines

Phabricator/

PhabricatorPayloadAnalyzer.php

2 lines

Diff 1956

View Options

app/Analyzers/BasePayloadAnalyzer.php